Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect detection and confusing licenses in https://raw.githubusercontent.com/Stuk/jszip/ #4112

Open
pombredanne opened this issue Jan 20, 2025 · 0 comments

Comments

@pombredanne
Copy link
Member

We are not detecting licenses exactly right in https://github.com/Stuk/jszip

  • In LICENSE.markdown, we should detect as mit or gpl-3.0. Here the GPL mention does not state other later versions:
dual licensed. At your choice you may use it under the MIT license *or* the GPLv3
license.

The text further contains a full MIT and a truncated GPL 3 text, where the tail text after END OF TERMS AND CONDITIONS has been removed.

License
-------

JSZip is dual-licensed. You may use it under the MIT license *or* the GPLv3
license. See [LICENSE.markdown](LICENSE.markdown).
Dual licenced under the MIT license or GPLv3. See https://raw.github.com/Stuk/jszip/main/LICENSE.markdown.

JSZip uses the library pako released under the MIT license :
https://github.com/nodeca/pako/blob/main/LICENSE

Here again no other GPL version. The upstream copyright notice has not been carried forward,

A ScanCode.io scan of the code from https://github.com/Stuk/jszip/archive/2ceb998e29d4171b4f3f2ecab1a2195c696543c0.zip attached shows that there is also code under the zlib license likely from https://github.com/nodeca/pako/ (and many other licenses but for the PKzip spec, as well as several test files, examples and documentation, but not core code, therefore I ignore these for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant