Koa Support

[MarkHerhold]

Hi @abbr, I was wondering if you had any plans to support koa or if you had any thoughts on the issue. I'll probably fork this repo and attempt to get NodeSSPI to work with koa in the coming weeks.

Any thoughts on the issue would be much appreciated.

[abbr]

NodeSSPI is agnostic to web framework, as long as running on Node.js and Windows. Do you find any specific issue?

[MarkHerhold]

@abbr Yes, Koa tries to be smart about how it handles requests, so when NodeSSPI calls res.end(), the request is complete but and Koa will later try to add headers to the response and end it itself. This causes a "Can't set headers after they are sent" error.

I believe the "appropriate" way to handle this in Koa is to make NodeSSPI act as middleware, where user information is added to the req object (e.g. req.connection.userGroups) if authorized. If the user isn't authorized, the middleware should not yield next;.

For example, NodeSSPI middleware could look like this:

app.use(function *(next){
  let isAuthorized = NodeSSPI.isAuthorized();

  if (isAuthorized) {
    yield next;
  } else {
    yield NodeSSPI.authorize();
    // yield next; // maybe?
    // NodeSSPI.authorize would set the appropriate headers internally but not call `res.end()`
  }
});

https://github.com/koajs/koa/blob/master/docs/guide.md#guide

[MarkHerhold]

I actually initially expected NodeSSPI to behave a bit more like a library that simply checks if a user is authorized and then provide a function to authorize the user, but it looks like NodeSSO is pretty dependent on being able to directly manipulate the requests...

[abbr]

Have you tried to set authoritative to false? This option effectively skipping calling response.end() by NodeSSPI.

[MarkHerhold]

@abbr I have not, this is wonderful! I'll let you know what I come up with.

[MarkHerhold]

I've been unable to work on this so I'm closing for the time being.

[emahuni]

please take a look at #80 answers it worked for me

[gotenks]

I support comments made by @MarkHerhold, because neither "authoritative" option, nor solution posted at #80 worked for me. The problem with solution at #80 is, that it bypasses koa normal response processing, which is actually a problem in my case, and it is not supported by koa developers, since it is considered a hack ...