Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error messages being passed to reject in GoogleLoginProvider.getAccessToken() #746

Open
lwestfall opened this issue Jan 1, 2024 · 1 comment

Comments

@lwestfall
Copy link

The error messages in these logical branches should be swapped.

I can PR sometime this week, I'll so be refactoring all error messages as readonly strings a la SocialAuthService.

if (!this._tokenClient) {
if (this._socialUser.value) {
reject(
'No token client was instantiated, you should specify some scopes.'
);
} else {
reject('You should be logged-in first.');
}
} else {

@Heatmanofurioso
Copy link
Collaborator

@lwestfall Thanks for the dedicated effort here.
I've been swamped with work, and haven't been able to do any PRs myself.
Looking forward to it if you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants