Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't detect video from notifications #73

Open
krystian3w opened this issue Aug 13, 2022 · 1 comment
Open

Don't detect video from notifications #73

krystian3w opened this issue Aug 13, 2022 · 1 comment

Comments

@krystian3w
Copy link

krystian3w commented Aug 13, 2022

  1. open this banned video https://www.youtube.com/watch?v=K2ZIurR47Y8
  2. open any other video from notification bell (very optional possible use button "open homepage" and click on any video)
  3. windowed fullscreen don't started
@Zren
Copy link
Owner

Zren commented Aug 13, 2022

Hmm, this is probably a bug in the "video unavailable" instead of something notification specific. If I click that video, then go to the homepage for a video, it doesn't work (haven't tested the notification bell yet since I don't use that feature).

This probably has to do with how I disable the script when it encounters a unviewable video.

ytwp.detectPlayerUnavailable = function() {
if (document.querySelector('[player-unavailable]')) {
ytwp.event.removeBodyClass()
}
}

When it detect an error, it removes the body.ytwp-window-player CSS class which is the same as toggling the script with the w key. This can be confirmed by pressing w to reenable the script on the working video page.

Looks like I need to figure out a way to fix the video error detection to be a temporary disable of the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants