Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder having false positives #20

Open
Zerthox opened this issue May 19, 2022 · 3 comments
Open

Reminder having false positives #20

Zerthox opened this issue May 19, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Zerthox
Copy link
Owner

Zerthox commented May 19, 2022

Due events reported by Arc being out of order sometimes, the plugin might receive an event that fits the current criteria of having a later timestamp than initial buff events before all initial buff events have been received. This may lead to a false positive.

In order to fix this, the plugin would have to either put out of order events in a queue, which would essentially be sequentializing the whole thing. Or it could keep track of event ids (in a sorted vector or btree set?) and only trigger a reminder when it is certain all initial buff events have been received.

@Zerthox Zerthox added the bug Something isn't working label May 19, 2022
@Zerthox
Copy link
Owner Author

Zerthox commented May 19, 2022

Tracking event ids does not work out since Arc delays or skips events. Forcing sequential processing most likely also wont work since the plugin has no idea when it has to wait for an older event and when Arc simply will not report it.

@Zerthox
Copy link
Owner Author

Zerthox commented May 19, 2022

The minimum time difference to last buff initial event added in 130aabd should reduce the chances of false positives. A guaranteed fix seems impossible.

@Zerthox
Copy link
Owner Author

Zerthox commented Mar 17, 2023

It seems like an increased number of false positives on encounter start are occuring with more recent versions of ArcDPS. Need to look into whether something related to buff initial events changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant