Skip to content

Commit 30aa841

Browse files
authored
Remove unused unmountIDFromEnvironment (facebook#7259)
I got rid of the need for this a few months ago.
1 parent 85dcbf8 commit 30aa841

File tree

4 files changed

+0
-31
lines changed

4 files changed

+0
-31
lines changed

src/renderers/dom/shared/ReactComponentBrowserEnvironment.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,6 @@ var ReactComponentBrowserEnvironment = {
2727
replaceNodeWithMarkup:
2828
DOMChildrenOperations.dangerouslyReplaceNodeWithMarkup,
2929

30-
/**
31-
* If a particular environment requires that some resources be cleaned up,
32-
* specify this in the injected Mixin. In the DOM, we would likely want to
33-
* purge any cached node ID lookups.
34-
*
35-
* @private
36-
*/
37-
unmountIDFromEnvironment: function(rootNodeID) {
38-
},
39-
4030
};
4131

4232
module.exports = ReactComponentBrowserEnvironment;

src/renderers/dom/shared/ReactDOMComponent.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ var EventConstants = require('EventConstants');
2323
var EventPluginHub = require('EventPluginHub');
2424
var EventPluginRegistry = require('EventPluginRegistry');
2525
var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter');
26-
var ReactComponentBrowserEnvironment =
27-
require('ReactComponentBrowserEnvironment');
2826
var ReactDOMButton = require('ReactDOMButton');
2927
var ReactDOMComponentFlags = require('ReactDOMComponentFlags');
3028
var ReactDOMComponentTree = require('ReactDOMComponentTree');
@@ -1212,7 +1210,6 @@ ReactDOMComponent.Mixin = {
12121210
this.unmountChildren(safely);
12131211
ReactDOMComponentTree.uncacheNode(this);
12141212
EventPluginHub.deleteAllListeners(this);
1215-
ReactComponentBrowserEnvironment.unmountIDFromEnvironment(this._rootNodeID);
12161213
this._rootNodeID = null;
12171214
this._domID = null;
12181215
this._wrapperState = null;

src/renderers/native/ReactNativeComponentEnvironment.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,6 @@ var ReactNativeComponentEnvironment = {
2020

2121
replaceNodeWithMarkup: ReactNativeDOMIDOperations.dangerouslyReplaceNodeWithMarkupByID,
2222

23-
/**
24-
* Nothing to do for UIKit bridge.
25-
*
26-
* @private
27-
*/
28-
unmountIDFromEnvironment: function(/*rootNodeID*/) {
29-
30-
},
31-
3223
/**
3324
* @param {DOMElement} Element to clear.
3425
*/

src/renderers/shared/stack/reconciler/ReactComponentEnvironment.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@ var injected = false;
1717

1818
var ReactComponentEnvironment = {
1919

20-
/**
21-
* Optionally injectable environment dependent cleanup hook. (server vs.
22-
* browser etc). Example: A browser system caches DOM nodes based on component
23-
* ID and must remove that cache entry when this instance is unmounted.
24-
*/
25-
unmountIDFromEnvironment: null,
26-
2720
/**
2821
* Optionally injectable hook for swapping out mount images in the middle of
2922
* the tree.
@@ -42,8 +35,6 @@ var ReactComponentEnvironment = {
4235
!injected,
4336
'ReactCompositeComponent: injectEnvironment() can only be called once.'
4437
);
45-
ReactComponentEnvironment.unmountIDFromEnvironment =
46-
environment.unmountIDFromEnvironment;
4738
ReactComponentEnvironment.replaceNodeWithMarkup =
4839
environment.replaceNodeWithMarkup;
4940
ReactComponentEnvironment.processChildrenUpdates =

0 commit comments

Comments
 (0)