Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - Unexpected behavior when stopping and starting dialogue #311

Open
dogboydog opened this issue Feb 27, 2025 · 0 comments
Open

v3 - Unexpected behavior when stopping and starting dialogue #311

dogboydog opened this issue Feb 27, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@dogboydog
Copy link
Contributor

What is the current behavior?
When calling Stop() on the DialogueRunner and then restarting dialogue, and then starting dialogue, the first line of dialogue in the new node is not displayed, and only part of the second line is displayed. This happens whether StartDialogue is called immediately after Stop or after onDialogueComplete is triggered. Waiting a frame or for N seconds after Stop() avoids the issue.

start_Stop_bug_unity.mov

Discovered in the Godot port in this issue, where I observed in the debugger that two calls to RunLineAsync run simultaneously when the issue occurs (screenshots in the Godot issue)
YarnSpinnerTool/YarnSpinner-Godot#86

Please provide the steps to reproduce, and if possible a minimal demo of the problem:
Run the sample scene and click the Normal Bid or onDialogueComplete Bid buttons
Reproduction project
StartStopBug.zip

What is the expected behavior?
Maybe some of these cases are not expected to work, but I would think at least the onDialogueComplete case should work ideally?

Please tell us about your environment:

  • Yarn Spinner Version: v3.0.0-beta1
  • Unity Version: 2022.3.53f1
@dogboydog dogboydog added the bug Something isn't working label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant