Skip to content

Commit 5330a64

Browse files
Nicole BazeSiva Addepalli
authored andcommitted
xilpm: versal: server: Fix bug in AIE2 zeroization
There is a bug in AIE2 zeriozation function when polling for memory zeroization complete. Currently the entire memory register is being checked against zero but instead we need to check the bits specific to the memory tiles. This patch updates the zeroization check by adding a mask so that only the desired bits are checked for zero. Signed-off-by: Nicole Baze <[email protected]> Acked-by: Jesus De Haro <[email protected]>
1 parent 27ddad7 commit 5330a64

File tree

1 file changed

+6
-6
lines changed
  • lib/sw_services/xilpm/src/versal/server

1 file changed

+6
-6
lines changed

lib/sw_services/xilpm/src/versal/server/xpm_aie.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2030,16 +2030,16 @@ static XStatus Aie2_Zeroization(const XPm_Device *AieDev, u32 ColStart, u32 ColE
20302030
(XST_SUCCESS != CoreZeroStatus) ||
20312031
(XST_SUCCESS != MemZeroStatus)) {
20322032

2033-
if (0U == AieRead64(AIE2_TILE_BADDR(NocAddress, Col, Mrow) +
2034-
AIE2_MEM_TILE_MODULE_MEM_CTRL_OFFSET)) {
2033+
if (0U == (AIE2_MEM_TILE_MODULE_MEM_CTRL_MEM_ZEROISATION_MASK &
2034+
(AieRead64(AIE2_TILE_BADDR(NocAddress, Col, Mrow) + AIE2_MEM_TILE_MODULE_MEM_CTRL_OFFSET)))) {
20352035
MemTileZeroStatus = XST_SUCCESS;
20362036
}
2037-
if (0U == AieRead64(AIE2_TILE_BADDR(NocAddress, Col, Row) +
2038-
AIE2_CORE_MODULE_MEM_CTRL_OFFSET)) {
2037+
if (0U == (AIE2_CORE_MODULE_MEM_CTRL_MEM_ZEROISATION_MASK &
2038+
(AieRead64(AIE2_TILE_BADDR(NocAddress, Col, Row) + AIE2_CORE_MODULE_MEM_CTRL_OFFSET)))) {
20392039
CoreZeroStatus = XST_SUCCESS;
20402040
}
2041-
if (0U == AieRead64(AIE2_TILE_BADDR(NocAddress, Col, Row) +
2042-
AIE2_MEM_MODULE_MEM_CTRL_OFFSET)) {
2041+
if (0U == (AIE2_MEM_MODULE_MEM_CTRL_MEM_ZEROISATION_MASK &
2042+
(AieRead64(AIE2_TILE_BADDR(NocAddress, Col, Row) + AIE2_MEM_MODULE_MEM_CTRL_OFFSET)))) {
20432043
MemZeroStatus = XST_SUCCESS;
20442044
}
20452045

0 commit comments

Comments
 (0)