Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken config_bar argument of the DPDK driver #322

Open
deeonis-ru opened this issue Jan 30, 2025 · 0 comments
Open

Broken config_bar argument of the DPDK driver #322

deeonis-ru opened this issue Jan 30, 2025 · 0 comments

Comments

@deeonis-ru
Copy link

The commit 87c54f5 broke the proper handling of config_bar QDMA DPDK driver. The reason of issue is in qdma_ethdev.c file 87c54f5#diff-a0cb1aa469b6df1f0d60ec7522c4fdd1b1c55f4d92c7ae8cefbeb49169f21e41

In particular, the call of qdma_check_kvargs function was moved from line 600 to line 647, and qdma_identify_bars function is executed before handling the config_bar argument. Hence, qdma_identify_bars always check the BAR0 instead of the configured bar.

The easiest way to fix it is just moving the call of qdma_check_kvargs back. It doesn't look criminal at first glance, at least. But I'm not sure, cause definitely there was a reason for such code modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant