Skip to content

Commit f28ce76

Browse files
committed
Review feedback: add !isTesSuccess(ter)
1 parent e35f569 commit f28ce76

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

src/xrpld/app/tx/detail/VaultClawback.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ VaultClawback::doApply()
255255
vaultAccount,
256256
sharesDestroyed,
257257
j_,
258-
WaiveTransferFee::Yes))
258+
WaiveTransferFee::Yes);
259+
!isTesSuccess(ter))
259260
return ter;
260261

261262
// Try to remove MPToken for shares, if the holder balance is zero. Vault
@@ -280,7 +281,8 @@ VaultClawback::doApply()
280281
account_,
281282
assetsRecovered,
282283
j_,
283-
WaiveTransferFee::Yes))
284+
WaiveTransferFee::Yes);
285+
!isTesSuccess(ter))
284286
return ter;
285287

286288
// Sanity check

src/xrpld/app/tx/detail/VaultDeposit.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,8 @@ VaultDeposit::doApply()
292292
vaultAccount,
293293
assetsDeposited,
294294
j_,
295-
WaiveTransferFee::Yes))
295+
WaiveTransferFee::Yes);
296+
!isTesSuccess(ter))
296297
return ter;
297298

298299
// Sanity check
@@ -317,7 +318,8 @@ VaultDeposit::doApply()
317318
account_,
318319
sharesCreated,
319320
j_,
320-
WaiveTransferFee::Yes))
321+
WaiveTransferFee::Yes);
322+
!isTesSuccess(ter))
321323
return ter;
322324

323325
return tesSUCCESS;

src/xrpld/app/tx/detail/VaultWithdraw.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,8 @@ VaultWithdraw::doApply()
270270
vaultAccount,
271271
sharesRedeemed,
272272
j_,
273-
WaiveTransferFee::Yes))
273+
WaiveTransferFee::Yes);
274+
!isTesSuccess(ter))
274275
return ter;
275276

276277
// Try to remove MPToken for shares, if the account balance is zero. Vault
@@ -301,7 +302,8 @@ VaultWithdraw::doApply()
301302
dstAcct,
302303
assetsWithdrawn,
303304
j_,
304-
WaiveTransferFee::Yes))
305+
WaiveTransferFee::Yes);
306+
!isTesSuccess(ter))
305307
return ter;
306308

307309
// Sanity check

0 commit comments

Comments
 (0)