Update to eslint v9, typescript-eslint v8 (microsoft#59518)

jakebailey · web-flow · commit 01a874a8baf6 · 2024-08-12T17:13:24.000-07:00
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -123,24 +123,15 @@ export default tseslint.config(
             "@typescript-eslint/no-var-requires": "off",
             "@typescript-eslint/no-empty-interface": "off",
             "@typescript-eslint/no-explicit-any": "off",
-            "@typescript-eslint/ban-types": [
-                "error",
-                {
-                    extendDefaults: true,
-                    types: {
-                        // This is theoretically good, but ts-eslint appears to mistake our declaration of Symbol for the global Symbol type.
-                        // See: https://github.com/typescript-eslint/typescript-eslint/issues/7306
-                        "Symbol": false,
-                        "{}": false, // {} is a totally useful and valid type.
-                    },
-                },
-            ],
+            "@typescript-eslint/no-empty-object-type": "off", // {} is a totally useful and valid type.
+            "@typescript-eslint/no-require-imports": "off",
             "@typescript-eslint/no-unused-vars": [
                 "warn",
                 {
                     // Ignore: (solely underscores | starting with exactly one underscore)
                     argsIgnorePattern: "^(_+$|_[^_])",
                     varsIgnorePattern: "^(_+$|_[^_])",
+                    // Not setting an ignore pattern for caught errors; those can always be safely removed.
                 },
             ],
             "@typescript-eslint/no-inferrable-types": "off",
@@ -239,7 +230,8 @@ export default tseslint.config(
             "@typescript-eslint/interface-name-prefix": "off",
             "@typescript-eslint/prefer-function-type": "off",
             "@typescript-eslint/unified-signatures": "off",
-            "@typescript-eslint/ban-types": "off",
+            "@typescript-eslint/no-unsafe-function-type": "off",
+            "@typescript-eslint/no-wrapper-object-types": "off",
             "@typescript-eslint/no-unused-vars": "off",
 
             // scripts/eslint/rules
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
         "@dprint/formatter": "^0.4.1",
         "@dprint/typescript": "0.91.6",
         "@esfx/canceltoken": "^1.0.0",
-        "@eslint/js": "^8.57.0",
+        "@eslint/js": "^9.9.0",
         "@octokit/rest": "^21.0.1",
         "@types/chai": "^4.3.17",
         "@types/diff": "^5.2.1",
@@ -52,34 +52,35 @@
         "@types/node": "latest",
         "@types/source-map-support": "^0.5.10",
         "@types/which": "^3.0.4",
-        "@typescript-eslint/utils": "^7.18.0",
-        "azure-devops-node-api": "^14.0.1",
+        "@typescript-eslint/rule-tester": "^8.1.0",
+        "@typescript-eslint/utils": "^8.1.0",
+        "azure-devops-node-api": "^14.0.2",
         "c8": "^10.1.2",
         "chai": "^4.5.0",
         "chalk": "^4.1.2",
         "chokidar": "^3.6.0",
         "diff": "^5.2.0",
         "dprint": "^0.47.2",
         "esbuild": "^0.23.0",
-        "eslint": "^8.57.0",
-        "eslint-formatter-autolinkable-stylish": "^1.3.0",
+        "eslint": "^9.9.0",
+        "eslint-formatter-autolinkable-stylish": "^1.4.0",
         "fast-xml-parser": "^4.4.1",
         "glob": "^10.4.5",
         "globals": "^15.9.0",
         "hereby": "^1.9.0",
         "jsonc-parser": "^3.3.1",
-        "knip": "^5.27.0",
+        "knip": "^5.27.2",
         "minimist": "^1.2.8",
-        "mocha": "^10.7.0",
+        "mocha": "^10.7.3",
         "mocha-fivemat-progress-reporter": "^0.1.0",
-        "monocart-coverage-reports": "^2.10.0",
+        "monocart-coverage-reports": "^2.10.2",
         "ms": "^2.1.3",
         "node-fetch": "^3.3.2",
-        "playwright": "^1.45.3",
+        "playwright": "^1.46.0",
         "source-map-support": "^0.5.21",
         "tslib": "^2.6.3",
         "typescript": "^5.5.4",
-        "typescript-eslint": "^7.18.0",
+        "typescript-eslint": "^8.1.0",
         "which": "^3.0.1"
     },
     "overrides": {
diff --git a/scripts/eslint/tests/argument-trivia.test.cjs b/scripts/eslint/tests/argument-trivia.test.cjs
@@ -2,10 +2,11 @@ const { RuleTester } = require("./support/RuleTester.cjs");
 const rule = require("../rules/argument-trivia.cjs");
 
 const ruleTester = new RuleTester({
-    parserOptions: {
-        warnOnUnsupportedTypeScriptVersion: false,
+    languageOptions: {
+        parserOptions: {
+            warnOnUnsupportedTypeScriptVersion: false,
+        },
     },
-    parser: require.resolve("@typescript-eslint/parser"),
 });
 
 ruleTester.run("argument-trivia", rule, {
diff --git a/scripts/eslint/tests/debug-assert.test.cjs b/scripts/eslint/tests/debug-assert.test.cjs
@@ -2,10 +2,11 @@ const { RuleTester } = require("./support/RuleTester.cjs");
 const rule = require("../rules/debug-assert.cjs");
 
 const ruleTester = new RuleTester({
-    parserOptions: {
-        warnOnUnsupportedTypeScriptVersion: false,
+    languageOptions: {
+        parserOptions: {
+            warnOnUnsupportedTypeScriptVersion: false,
+        },
     },
-    parser: require.resolve("@typescript-eslint/parser"),
 });
 
 ruleTester.run("debug-assert", rule, {
diff --git a/scripts/eslint/tests/js-extensions.cjs b/scripts/eslint/tests/js-extensions.cjs
@@ -2,10 +2,11 @@ const { RuleTester } = require("./support/RuleTester.cjs");
 const rule = require("../rules/js-extensions.cjs");
 
 const ruleTester = new RuleTester({
-    parserOptions: {
-        warnOnUnsupportedTypeScriptVersion: false,
+    languageOptions: {
+        parserOptions: {
+            warnOnUnsupportedTypeScriptVersion: false,
+        },
     },
-    parser: require.resolve("@typescript-eslint/parser"),
 });
 
 ruleTester.run("js-extensions", rule, {
diff --git a/scripts/eslint/tests/no-in-operator.test.cjs b/scripts/eslint/tests/no-in-operator.test.cjs
@@ -2,10 +2,11 @@ const { RuleTester } = require("./support/RuleTester.cjs");
 const rule = require("../rules/no-in-operator.cjs");
 
 const ruleTester = new RuleTester({
-    parserOptions: {
-        warnOnUnsupportedTypeScriptVersion: false,
+    languageOptions: {
+        parserOptions: {
+            warnOnUnsupportedTypeScriptVersion: false,
+        },
     },
-    parser: require.resolve("@typescript-eslint/parser"),
 });
 
 ruleTester.run("no-in-operator", rule, {
diff --git a/scripts/eslint/tests/no-keywords.test.cjs b/scripts/eslint/tests/no-keywords.test.cjs
@@ -2,10 +2,11 @@ const { RuleTester } = require("./support/RuleTester.cjs");
 const rule = require("../rules/no-keywords.cjs");
 
 const ruleTester = new RuleTester({
-    parserOptions: {
-        warnOnUnsupportedTypeScriptVersion: false,
+    languageOptions: {
+        parserOptions: {
+            warnOnUnsupportedTypeScriptVersion: false,
+        },
     },
-    parser: require.resolve("@typescript-eslint/parser"),
 });
 
 ruleTester.run("no-keywords", rule, {
diff --git a/scripts/eslint/tests/only-arrow-functions.test.cjs b/scripts/eslint/tests/only-arrow-functions.test.cjs
@@ -2,10 +2,11 @@ const { RuleTester } = require("./support/RuleTester.cjs");
 const rule = require("../rules/only-arrow-functions.cjs");
 
 const ruleTester = new RuleTester({
-    parserOptions: {
-        warnOnUnsupportedTypeScriptVersion: false,
+    languageOptions: {
+        parserOptions: {
+            warnOnUnsupportedTypeScriptVersion: false,
+        },
     },
-    parser: require.resolve("@typescript-eslint/parser"),
 });
 
 ruleTester.run("only-arrow-functions", rule, {
diff --git a/scripts/eslint/tests/support/RuleTester.cjs b/scripts/eslint/tests/support/RuleTester.cjs
@@ -1,6 +1,9 @@
 const path = require("path");
-const { TSESLint } = require("@typescript-eslint/utils");
+const Mocha = require("mocha");
+const { RuleTester } = require("@typescript-eslint/rule-tester");
+
+RuleTester.afterAll = Mocha.after;
 
 module.exports.ROOT_DIR = path.join(process.cwd(), "scripts", "eslint", "tests", "fixtures");
 module.exports.FILENAME = path.join(module.exports.ROOT_DIR, "file.ts");
-module.exports.RuleTester = TSESLint.RuleTester;
+module.exports.RuleTester = RuleTester;
diff --git a/scripts/failed-tests.cjs b/scripts/failed-tests.cjs
@@ -45,7 +45,7 @@ class FailedTestsReporter extends Mocha.reporters.Base {
                 try {
                     reporter = require(reporterOptions.reporter);
                 }
-                catch (_) {
+                catch {
                     reporter = require(path.resolve(process.cwd(), reporterOptions.reporter));
                 }
             }
diff --git a/scripts/find-unused-diganostic-messages.mjs b/scripts/find-unused-diganostic-messages.mjs
@@ -18,7 +18,7 @@ startOfDiags.split(EOL).forEach(line => {
         execSync(`grep -rnw 'src' -e 'Diagnostics.${diagName}'`).toString();
         process.stdout.write(".");
     }
-    catch (error) {
+    catch {
         missingNames.push(diagName);
         process.stdout.write("x");
     }
diff --git a/src/compiler/sys.ts b/src/compiler/sys.ts
@@ -1792,7 +1792,7 @@ export let sys: System = (() => {
             try {
                 buffer = _fs.readFileSync(fileName);
             }
-            catch (e) {
+            catch {
                 return undefined;
             }
             let len = buffer.length;
@@ -1863,7 +1863,7 @@ export let sys: System = (() => {
                                 continue;
                             }
                         }
-                        catch (e) {
+                        catch {
                             continue;
                         }
                     }
@@ -1882,7 +1882,7 @@ export let sys: System = (() => {
                 directories.sort();
                 return { files, directories };
             }
-            catch (e) {
+            catch {
                 return emptyFileSystemEntries;
             }
         }
@@ -1911,7 +1911,7 @@ export let sys: System = (() => {
                         return false;
                 }
             }
-            catch (e) {
+            catch {
                 return false;
             }
             finally {
@@ -1952,7 +1952,7 @@ export let sys: System = (() => {
             try {
                 return statSync(path)?.mtime;
             }
-            catch (e) {
+            catch {
                 return undefined;
             }
             finally {
@@ -1964,7 +1964,7 @@ export let sys: System = (() => {
             try {
                 _fs.utimesSync(path, time, time);
             }
-            catch (e) {
+            catch {
                 return;
             }
         }
@@ -1973,7 +1973,7 @@ export let sys: System = (() => {
             try {
                 return _fs.unlinkSync(path);
             }
-            catch (e) {
+            catch {
                 return;
             }
         }
diff --git a/src/compiler/utilitiesPublic.ts b/src/compiler/utilitiesPublic.ts
@@ -723,7 +723,7 @@ export function validateLocaleAndSetLanguage(
         try {
             fileContents = sys.readFile(filePath);
         }
-        catch (e) {
+        catch {
             if (errors) {
                 errors.push(createCompilerDiagnostic(Diagnostics.Unable_to_open_file_0, filePath));
             }
diff --git a/src/compiler/watchUtilities.ts b/src/compiler/watchUtilities.ts
@@ -198,7 +198,7 @@ export function createCachedDirectoryStructureHost(host: DirectoryStructureHost,
         try {
             return createCachedFileSystemEntries(rootDir, rootDirPath);
         }
-        catch (_e) {
+        catch {
             // If there is exception to read directories, dont cache the result and direct the calls to host
             Debug.assert(!cachedReadDirectoryResult.has(ensureTrailingDirectorySeparator(rootDirPath)));
             return undefined;
diff --git a/src/harness/harnessUtils.ts b/src/harness/harnessUtils.ts
@@ -41,7 +41,7 @@ export function readTestFile(path: string) {
     try {
         content = Harness.IO.readFile(Harness.userSpecifiedRoot + path);
     }
-    catch (err) {
+    catch {
         return undefined;
     }
 
diff --git a/src/tsserver/nodeServer.ts b/src/tsserver/nodeServer.ts
@@ -124,7 +124,7 @@ export function initializeNodeSystem(): StartInput {
                 try {
                     this.fd = fs.openSync(this.logFilename, "w");
                 }
-                catch (_) {
+                catch {
                     // swallow the error and keep logging disabled if file cannot be opened
                 }
             }
@@ -280,7 +280,7 @@ export function initializeNodeSystem(): StartInput {
         const factory = require("./cancellationToken.js");
         cancellationToken = factory(sys.args);
     }
-    catch (e) {
+    catch {
         cancellationToken = ts.server.nullCancellationToken;
     }
 
diff --git a/src/typingsInstaller/nodeTypingsInstaller.ts b/src/typingsInstaller/nodeTypingsInstaller.ts
@@ -28,7 +28,7 @@ class FileLog implements ts.server.typingsInstaller.Log {
         try {
             fs.appendFileSync(this.logFile, `[${ts.server.nowString()}] ${text}${sys.newLine}`);
         }
-        catch (e) {
+        catch {
             this.logFile = undefined;
         }
     };

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ class FailedTestsReporter extends Mocha.reporters.Base {`
`45`	`45`	`try {`
`46`	`46`	`reporter = require(reporterOptions.reporter);`
`47`	`47`	`}`
`48`		`- catch (_) {`
	`48`	`+ catch {`
`49`	`49`	`reporter = require(path.resolve(process.cwd(), reporterOptions.reporter));`
`50`	`50`	`}`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ startOfDiags.split(EOL).forEach(line => {`
`18`	`18`	execSync(`grep -rnw 'src' -e 'Diagnostics.${diagName}'`).toString();
`19`	`19`	`process.stdout.write(".");`
`20`	`20`	`}`
`21`		`- catch (error) {`
	`21`	`+ catch {`
`22`	`22`	`missingNames.push(diagName);`
`23`	`23`	`process.stdout.write("x");`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1792,7 +1792,7 @@ export let sys: System = (() => {`
`1792`	`1792`	`try {`
`1793`	`1793`	`buffer = _fs.readFileSync(fileName);`
`1794`	`1794`	`}`
`1795`		`- catch (e) {`
	`1795`	`+ catch {`
`1796`	`1796`	`return undefined;`
`1797`	`1797`	`}`
`1798`	`1798`	`let len = buffer.length;`
`@@ -1863,7 +1863,7 @@ export let sys: System = (() => {`
`1863`	`1863`	`continue;`
`1864`	`1864`	`}`
`1865`	`1865`	`}`
`1866`		`- catch (e) {`
	`1866`	`+ catch {`
`1867`	`1867`	`continue;`
`1868`	`1868`	`}`
`1869`	`1869`	`}`
`@@ -1882,7 +1882,7 @@ export let sys: System = (() => {`
`1882`	`1882`	`directories.sort();`
`1883`	`1883`	`return { files, directories };`
`1884`	`1884`	`}`
`1885`		`- catch (e) {`
	`1885`	`+ catch {`
`1886`	`1886`	`return emptyFileSystemEntries;`
`1887`	`1887`	`}`
`1888`	`1888`	`}`
`@@ -1911,7 +1911,7 @@ export let sys: System = (() => {`
`1911`	`1911`	`return false;`
`1912`	`1912`	`}`
`1913`	`1913`	`}`
`1914`		`- catch (e) {`
	`1914`	`+ catch {`
`1915`	`1915`	`return false;`
`1916`	`1916`	`}`
`1917`	`1917`	`finally {`
`@@ -1952,7 +1952,7 @@ export let sys: System = (() => {`
`1952`	`1952`	`try {`
`1953`	`1953`	`return statSync(path)?.mtime;`
`1954`	`1954`	`}`
`1955`		`- catch (e) {`
	`1955`	`+ catch {`
`1956`	`1956`	`return undefined;`
`1957`	`1957`	`}`
`1958`	`1958`	`finally {`
`@@ -1964,7 +1964,7 @@ export let sys: System = (() => {`
`1964`	`1964`	`try {`
`1965`	`1965`	`_fs.utimesSync(path, time, time);`
`1966`	`1966`	`}`
`1967`		`- catch (e) {`
	`1967`	`+ catch {`
`1968`	`1968`	`return;`
`1969`	`1969`	`}`
`1970`	`1970`	`}`
`@@ -1973,7 +1973,7 @@ export let sys: System = (() => {`
`1973`	`1973`	`try {`
`1974`	`1974`	`return _fs.unlinkSync(path);`
`1975`	`1975`	`}`
`1976`		`- catch (e) {`
	`1976`	`+ catch {`
`1977`	`1977`	`return;`
`1978`	`1978`	`}`
`1979`	`1979`	`}`
Original file line number	Diff line number	Diff line change
`@@ -723,7 +723,7 @@ export function validateLocaleAndSetLanguage(`
`723`	`723`	`try {`
`724`	`724`	`fileContents = sys.readFile(filePath);`
`725`	`725`	`}`
`726`		`- catch (e) {`
	`726`	`+ catch {`
`727`	`727`	`if (errors) {`
`728`	`728`	`errors.push(createCompilerDiagnostic(Diagnostics.Unable_to_open_file_0, filePath));`
`729`	`729`	`}`
Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ export function createCachedDirectoryStructureHost(host: DirectoryStructureHost,`
`198`	`198`	`try {`
`199`	`199`	`return createCachedFileSystemEntries(rootDir, rootDirPath);`
`200`	`200`	`}`
`201`		`- catch (_e) {`
	`201`	`+ catch {`
`202`	`202`	`// If there is exception to read directories, dont cache the result and direct the calls to host`
`203`	`203`	`Debug.assert(!cachedReadDirectoryResult.has(ensureTrailingDirectorySeparator(rootDirPath)));`
`204`	`204`	`return undefined;`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export function readTestFile(path: string) {`
`41`	`41`	`try {`
`42`	`42`	`content = Harness.IO.readFile(Harness.userSpecifiedRoot + path);`
`43`	`43`	`}`
`44`		`- catch (err) {`
	`44`	`+ catch {`
`45`	`45`	`return undefined;`
`46`	`46`	`}`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ export function initializeNodeSystem(): StartInput {`
`124`	`124`	`try {`
`125`	`125`	`this.fd = fs.openSync(this.logFilename, "w");`
`126`	`126`	`}`
`127`		`- catch (_) {`
	`127`	`+ catch {`
`128`	`128`	`// swallow the error and keep logging disabled if file cannot be opened`
`129`	`129`	`}`
`130`	`130`	`}`
`@@ -280,7 +280,7 @@ export function initializeNodeSystem(): StartInput {`
`280`	`280`	`const factory = require("./cancellationToken.js");`
`281`	`281`	`cancellationToken = factory(sys.args);`
`282`	`282`	`}`
`283`		`- catch (e) {`
	`283`	`+ catch {`
`284`	`284`	`cancellationToken = ts.server.nullCancellationToken;`
`285`	`285`	`}`
`286`	`286`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class FileLog implements ts.server.typingsInstaller.Log {`
`28`	`28`	`try {`
`29`	`29`	fs.appendFileSync(this.logFile, `[${ts.server.nowString()}] ${text}${sys.newLine}`);
`30`	`30`	`}`
`31`		`- catch (e) {`
	`31`	`+ catch {`
`32`	`32`	`this.logFile = undefined;`
`33`	`33`	`}`
`34`	`34`	`};`