Skip to content

Commit 45c7074

Browse files
repejotarepejota
committed
Lint with Squid allow dockblocks and more code quality checks.
1 parent 18bbedb commit 45c7074

16 files changed

+265
-157
lines changed

‎examples/connect.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?php
2-
require_once __DIR__ . "/../vendor/autoload.php";
2+
require_once __DIR__.'/../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
5-
$connectionOptions
6-
->setHost('localhost')
7-
->setPort(4222);
5+
$connectionOptions->setHost('localhost')->setPort(4222);
86
$c = new Nats\Connection($connectionOptions);
97
$c->connect();
108
$c->close();

‎examples/connectauth.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
<?php
2-
require_once __DIR__ . "/../vendor/autoload.php";
2+
require_once __DIR__.'/../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
5-
$connectionOptions
6-
->setHost('localhost')
7-
->setPort(4222)
8-
->setUser("foo")
9-
->setPass("bar");
5+
$connectionOptions->setHost('localhost')->setPort(4222)->setUser('foo')->setPass('bar');
106
$c = new Nats\Connection($connectionOptions);
117
$c->connect();
128
$c->close();

‎examples/ping.php

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
<?php
2-
require_once __DIR__ . "/../vendor/autoload.php";
2+
require_once __DIR__.'/../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
5-
$connectionOptions
6-
->setHost('localhost')
7-
->setPort(4222);
5+
$connectionOptions->setHost('localhost')->setPort(4222);
86

9-
echo "Server: nats://" . $connectionOptions->getHost() . ":" . $connectionOptions->getPort() . PHP_EOL;
7+
echo 'Server: nats://'.$connectionOptions->getHost().':'.$connectionOptions->getPort().PHP_EOL;
108

119
$c = new Nats\Connection($connectionOptions);
1210
$c->connect();

‎examples/pubsub/pub.php

+7-9
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
<?php
2-
require_once __DIR__ . "/../../vendor/autoload.php";
2+
require_once __DIR__.'/../../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
5-
$connectionOptions
6-
->setHost('localhost')
7-
->setPort(4222);
5+
$connectionOptions->setHost('localhost')->setPort(4222);
86
$c = new Nats\Connection($connectionOptions);
97
$c->connect();
108

119
$c->reconnect();
1210

13-
$c->publish("foo", "bar");
14-
$c->publish("foo", "bar");
15-
$c->publish("foo", "bar");
16-
$c->publish("foo", "bar");
17-
$c->publish("foo", "bar");
11+
$c->publish('foo', 'bar');
12+
$c->publish('foo', 'bar');
13+
$c->publish('foo', 'bar');
14+
$c->publish('foo', 'bar');
15+
$c->publish('foo', 'bar');

‎examples/pubsub/sub.php

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
<?php
2-
require_once __DIR__ . "/../../vendor/autoload.php";
2+
require_once __DIR__.'/../../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
5-
$connectionOptions
6-
->setHost('localhost')
7-
->setPort(4222);
5+
$connectionOptions->setHost('localhost')->setPort(4222);
86
$c = new Nats\Connection($connectionOptions);
97
$c->connect();
108

119
$callback = function ($payload) {
1210
printf("Data: %s\r\n", $payload);
1311
};
1412

15-
$sid = $c->subscribe("foo", $callback);
13+
$sid = $c->subscribe('foo', $callback);
1614

1715
$c->wait(2);
1816

‎examples/reqres/req.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?php
2-
require_once __DIR__ . "/../../vendor/autoload.php";
2+
require_once __DIR__.'/../../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
55
$connectionOptions->setHost('localhost')->setPort(4222);

‎examples/reqres/res.php

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
<?php
2-
require_once __DIR__ . "/../../vendor/autoload.php";
2+
require_once __DIR__.'/../../vendor/autoload.php';
33

44
$connectionOptions = new \Nats\ConnectionOptions();
5-
$connectionOptions
6-
->setHost('localhost')
7-
->setPort(4222);
5+
$connectionOptions->setHost('localhost')->setPort(4222);
86
$c = new Nats\Connection($connectionOptions);
97
$c->connect();
108

119
$sid = $c->subscribe(
12-
"sayhello",
10+
'sayhello',
1311
function ($res) {
14-
$res->reply("Hello, " . $res->getBody() . " !!!");
12+
$res->reply('Hello, '.$res->getBody().' !!!');
1513
}
1614
);
1715

‎ruleset.xml

+27
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,34 @@
22
<ruleset name="Custom Standard">
33
<description>php-nats Coding Standards for Inline Documentation and Comments</description>
44

5+
<rule ref="Squiz.Functions">
6+
<!-- Conflicts with PSR2 -->
7+
<exclude name="Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals" />
8+
<exclude name="Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterDefault" />
9+
</rule>
10+
11+
<rule ref="Squiz.Files">
12+
<!-- Avoid to check for .inc files ... always use .php -->
13+
<exclude name="Squiz.Files.FileExtension.ClassFound" />
14+
</rule>
15+
16+
<rule ref="Squiz.WhiteSpace">
17+
<!-- Conflict with PSR2 -->
18+
<exclude name="Squiz.WhiteSpace.FunctionClosingBraceSpace.SpacingBeforeClose" />
19+
</rule>
20+
21+
<rule ref="Squiz.NamingConventions">
22+
<!-- Do not use underscore prefix for anything private -->
23+
<exclude name="Squiz.NamingConventions.ValidVariableName.PrivateNoUnderscore" />
24+
<exclude name="Squiz.NamingConventions.ValidFunctionName.PrivateNoUnderscore" />
25+
</rule>
26+
527
<rule ref="Squiz.Commenting">
28+
<exclude name="Squiz.WhiteSpace.FunctionSpacing.After" />
29+
<exclude name="Squiz.Commenting.LongConditionClosingComment.Missing" />
30+
<exclude name="Squiz.Commenting.ClosingDeclarationComment.Missing" />
31+
<!-- Don't need file doc comments -->
32+
<exclude name="Squiz.Commenting.FileComment.Missing" />
633
<!-- It is too early for PHP7 features to be required -->
734
<exclude name="Squiz.Commenting.FunctionComment.ScalarTypeHintMissing" />
835
</rule>

0 commit comments

Comments
 (0)