Skip to content

Commit 750e828

Browse files
mmargaryanvabrahamyanadobe
mmargaryan
authored andcommitted
fix: replace mousedown with pointerdown in click outside container
1 parent ea5138d commit 750e828

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

packages/core/src/internal/click-outside-container/click-outside-container.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ export default class ClickOutsideContainer extends React.PureComponent<Props> {
1313
public componentDidMount() {
1414
const eventTarget = this.props.customEventTarget ?? document;
1515
eventTarget.addEventListener("touchend", this.clickOutside, true);
16-
eventTarget.addEventListener("mousedown", this.clickOutside, true);
16+
eventTarget.addEventListener("pointerdown", this.clickOutside, true);
1717
eventTarget.addEventListener("contextmenu", this.clickOutside, true);
1818
}
1919

2020
public componentWillUnmount() {
2121
const eventTarget = this.props.customEventTarget ?? document;
2222
eventTarget.removeEventListener("touchend", this.clickOutside, true);
23-
eventTarget.removeEventListener("mousedown", this.clickOutside, true);
23+
eventTarget.removeEventListener("pointerdown", this.clickOutside, true);
2424
eventTarget.removeEventListener("contextmenu", this.clickOutside, true);
2525
}
2626

packages/core/test/data-editor.test.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
prep,
2121
sendClick,
2222
sendTouchClick,
23+
sendPointerClick,
2324
getCellCenterPositionForDefaultGrid,
2425
Context,
2526
standardBeforeEach,
@@ -1559,7 +1560,7 @@ describe("data-editor", () => {
15591560
const overlay = screen.getByDisplayValue("j");
15601561
expect(document.body.contains(overlay)).toBe(true);
15611562

1562-
sendClick(canvas, {
1563+
sendPointerClick(canvas, {
15631564
clientX: 300, // Col B
15641565
clientY: 36 + 32 * 5 + 16, // Row 1 (0 indexed)
15651566
});

packages/core/test/test-utils.tsx

+8
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,14 @@ export function sendTouchClick(el: Element | Node | Document | Window, options?:
4646
});
4747
}
4848

49+
export function sendPointerClick(el: Element | Node | Document | Window, options?: any): void {
50+
fireEvent.pointerDown(el, options);
51+
52+
fireEvent.pointerUp(el, options);
53+
54+
fireEvent.click(el, options);
55+
}
56+
4957
export const makeCell = (cell: Item): GridCell => {
5058
const [col, row] = cell;
5159
switch (col) {

0 commit comments

Comments
 (0)