Skip to content

Media: Use the default 40px button height in the media modal#12125

Open
t-hamano wants to merge 2 commits into
WordPress:trunkfrom
t-hamano:65428-fix-media-modal-button
Open

Media: Use the default 40px button height in the media modal#12125
t-hamano wants to merge 2 commits into
WordPress:trunkfrom
t-hamano:65428-fix-media-modal-button

Conversation

@t-hamano

@t-hamano t-hamano commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Alternatives to #12112

If the button size is 32px by default, many CSS overrides are required to match the height of other form elements such as input and select, which are 40px.

This PR changes the default button size from 32px to 40px in the media modal and attachment detail modal. While this PR is a bit aggressive, it should resolve all button size inconsistencies.

Trac ticket: https://core.trac.wordpress.org/ticket/65428

Screenshots

Attachment details modal

Before After
image image
image image

Image details

Before After
image image

Use of AI Tools

N/A

t-hamano and others added 2 commits June 8, 2026 21:44
Remove the button overrides that forced a 32px min-height in the media
modal and the edit attachment frame, letting buttons fall back to the
default 40px height. Adjust the thumbnail max-height calculation to
reserve 56px for the taller action buttons underneath, and clean up
some stray trailing whitespace.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Lower the top and bottom margins of the primary toolbar buttons from
14px to 10px to keep the toolbar height balanced now that the buttons
use the taller default 40px height.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@t-hamano t-hamano marked this pull request as ready for review June 8, 2026 12:57
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant