Media: Use the default 40px button height in the media modal#12125
Media: Use the default 40px button height in the media modal#12125t-hamano wants to merge 2 commits into
Conversation
Remove the button overrides that forced a 32px min-height in the media modal and the edit attachment frame, letting buttons fall back to the default 40px height. Adjust the thumbnail max-height calculation to reserve 56px for the taller action buttons underneath, and clean up some stray trailing whitespace. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Lower the top and bottom margins of the primary toolbar buttons from 14px to 10px to keep the toolbar height balanced now that the buttons use the taller default 40px height. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Alternatives to #12112
If the button size is 32px by default, many CSS overrides are required to match the height of other form elements such as input and select, which are 40px.
This PR changes the default button size from 32px to 40px in the media modal and attachment detail modal. While this PR is a bit aggressive, it should resolve all button size inconsistencies.
Trac ticket: https://core.trac.wordpress.org/ticket/65428
Screenshots
Attachment details modal
Image details
Use of AI Tools
N/A