Fix "strtolower(): Passing null to parameter #1 ($string) of type string is deprecated" on PHP >= 8.4

JanJakes · JanJakes · commit fe4a96f19473 · 2025-10-31T10:55:27.000+01:00
diff --git a/wp-includes/sqlite-ast/class-wp-sqlite-driver.php b/wp-includes/sqlite-ast/class-wp-sqlite-driver.php
@@ -2925,7 +2925,7 @@ private function execute_set_system_variable_statement(
 		 *          SET updatable_views_with_limit = OFF;   ERROR 1231 (42000)
 		 *          SET updatable_views_with_limit = false; SELECT @@updatable_views_with_limit; -> NO
 		 */
-		$lowercase_value = strtolower( $value );
+		$lowercase_value = null === $value ? null : strtolower( $value );
 		if ( 'on' === $lowercase_value || 'off' === $lowercase_value ) {
 			$value = 'on' === $lowercase_value ? 1 : 0;
 		}

Original file line number	Diff line number	Diff line change
`@@ -2925,7 +2925,7 @@ private function execute_set_system_variable_statement(`
`2925`	`2925`	`* SET updatable_views_with_limit = OFF; ERROR 1231 (42000)`
`2926`	`2926`	`* SET updatable_views_with_limit = false; SELECT @@updatable_views_with_limit; -> NO`
`2927`	`2927`	`*/`
`2928`		`- $lowercase_value = strtolower( $value );`
	`2928`	`+ $lowercase_value = null === $value ? null : strtolower( $value );`
`2929`	`2929`	`if ( 'on' === $lowercase_value \|\| 'off' === $lowercase_value ) {`
`2930`	`2930`	`$value = 'on' === $lowercase_value ? 1 : 0;`
`2931`	`2931`	`}`