Ensure that an index is also created using IF NOT EXISTS if it comes from a CREATE TABLE IF NOT EXISTS (#134)

Before this the unit test failed.

cc @JanJakes

---------

Co-authored-by: Ari Stathopoulos <[email protected]>
Co-authored-by: Brandon Payton <[email protected]>

Author: 3 people

tests/WP_SQLite_Query_Tests.php

@@ -537,6 +537,27 @@ public function testOnDuplicateKeyWithUnnamedKeys() {
 		);
 	}
 
+	public function testOnCreateTableIfNotExistsWithIndexAdded() {
+		$this->assertQuery(
+			'CREATE TABLE IF not EXISTS `test` (
+				`id` INT,
+				`name` VARCHAR(255),
+				`other` VARCHAR(255),
+				PRIMARY KEY (id),
+				UNIQUE KEY (name)
+			);'
+		);
+		$this->assertQuery(
+			'CREATE TABLE if   NOT   ExisTS `test` (
+				`id` INT,
+				`name` VARCHAR(255),
+				`other` VARCHAR(255),
+				PRIMARY KEY (id),
+				UNIQUE KEY (name)
+			);'
+		);
+	}
+
 	public function testShowColumns() {
 
 		$query = 'SHOW COLUMNS FROM wp_posts';

wp-includes/sqlite/class-wp-sqlite-translator.php

@@ -895,6 +895,8 @@ private function execute_create_table() {
 			')'
 		);
 
+		$if_not_exists = preg_match( '/\bIF\s+NOT\s+EXISTS\b/i', $create_query ) ? 'IF NOT EXISTS' : '';
+
 		$this->execute_sqlite_query( $create_query );
 		$this->results      = $this->last_exec_returned;
 		$this->return_value = $this->results;
@@ -907,7 +909,7 @@ private function execute_create_table() {
 			}
 			$index_name = $this->generate_index_name( $table->name, $constraint->name );
 			$this->execute_sqlite_query(
-				"CREATE $unique INDEX \"$index_name\" ON \"{$table->name}\" (\"" . implode( '", "', $constraint->columns ) . '")'
+				"CREATE $unique INDEX $if_not_exists \"$index_name\" ON \"{$table->name}\" (\"" . implode( '", "', $constraint->columns ) . '")'
 			);
 			$this->update_data_type_cache(
 				$table->name,