Optimized changeDetector.gd, some static typing

[ImmortalOctogen]

• changeDetector.gd now uses a thread, significantly increasing fps (at least on my laptop).
• load() replaced with preload(), for static file paths.
• other micro optimization, check comments

This is my first time contributing to other projects, and therefore, having poor experience working with git.
I started to write weeks ago, look for downgrades!

[Wolfyxon]

There are a few issues, but overall you did a good job.
I'll make a review soon and fix some bugs on my side before merging.

[Wolfyxon]

Please make the changes

[ImmortalOctogen]

It's okay when forked rep is 2 commits behind original?

[Wolfyxon]

Usually ok since the PR can be merged anyway (unless there are conflicts, but in this case there are not), but I recommend you to always sync so you can work with the current state of the original code and when I'm testing it, it has my latest changes.

Basically it makes everything easier, but it's usually still fine if you keep the fork behind.

[Wolfyxon]

There's a big issue, get_property_dict() can't be called on the separate thread.
Idk how to fix that yet.

[Wolfyxon]

call_deferred() doesn't return the called function's result.
Here's how it can be fixed:

func _ready() -> void:
	var t: Thread = Thread.new()
	refrate.wait_time = 0.1

	var root = EditorInterface.get_edited_scene_root() # Get scene root in the main thread

	refrate.timeout.connect(func():
		if t.start(cycle.bind(root)) == ERR_CANT_CREATE: # Pass `root` to the thread
			print_debug(error_string(ERR_CANT_CREATE))
			return
		while true:
			if not t.is_alive():
				t.wait_to_finish()
				break
	)

	add_child(refrate)
	refrate.start()

func cycle(root: Node) -> void:
	if not main: return
	if not root: return

        ....

[Wolfyxon]

I can't get the functions to properly talk to each on the separate threads.
You should split this PR to include your other optimizations and we'll figure out multithreading later.

And next time I recommend you commit more frequently so splitting a PR would be as simple as going back to an older commit and creating a branch off of it then submitting a PR.

[ImmortalOctogen]

I can't get the functions to properly talk to each on the separate threads. You should split this PR to include your other optimizations and we'll figure out multithreading later.

create other PR for multithreading issues, and leave this one for other optimizations?

[Wolfyxon]

Yeah, remove the multithreading changes for this PR.
Then you can later add them to a next PR or make a branch from an older commit and add submit a separate PR.

Also what version of Godot are you using and did you test if the multithreading works for you?

Btw, I wrote some development tips in the CONTRIBUTING.md file.

[ImmortalOctogen]

It doesn't work for me either, I probably hastened with writing code. Godot version 4.3.stable

Btw, I wrote some development tips in the CONTRIBUTING.md file.

uzful :D

[Wolfyxon]

It doesn't work for me either, I probably hastened with writing code.

Make sure to test it next time

Godot version 4.3.stable

Latest, good

[ImmortalOctogen]

On enabling plugin, this shows up:
res://addons/GodotTogether/src/scripts/changeDetector.gd:48 - Invalid access to property or key 'surface_material_override/0' on a base object of type 'MeshInstance3D'.
AnimationPlayer has no current animation.

tf this come from? Probably from my other project, where I testing plugin