You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the solution you'd like
A better way to handle signs while still maintaining cross-version compatibility; block.getType().name().toUpperCase().contains("SIGN") block.getType().toString().contains("SIGN") (pretty sure both will work just fine)
This will both, handle every sign variation (oak, dark oak, etc.) and handle wall and ground signs, all in one check.
Describe alternatives you've considered
What you have now may work, but it'll be very tedious to maintain over time.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
While it can be used to read block information, it can't be used to place blocks. For example SIGN_POST and WALL_SIGN would both return true when calling String#contains. So there isn't a distinctive difference between the two.
Having both the old system and the one you suggested makes the code more scattered and harder to maintain in my opinion.
It's strictly functional as a getter, not as a setter. I'd wager if you felt like supporting every sign type it'd definitely make it faster in the long run if used properly, I'm sure you could hack together a setter as well using a similar method. At the end of the day, it is up to you though.
Improvement request
Describe the solution you'd like
A better way to handle signs while still maintaining cross-version compatibility;
block.getType().name().toUpperCase().contains("SIGN")
block.getType().toString().contains("SIGN")
(pretty sure both will work just fine)This will both, handle every sign variation (oak, dark oak, etc.) and handle wall and ground signs, all in one check.
Describe alternatives you've considered
What you have now may work, but it'll be very tedious to maintain over time.
Additional context
N/A
The text was updated successfully, but these errors were encountered: