Skip to content

Commit f9dac70

Browse files
committed
global: remove TODO name graffiti
Googlers have a habit of graffiting their name in TODO items that then are never addressed, and other people won't go near those because they're marked territory of another animal. I've been gradually cleaning these up as I see them, but this commit just goes all the way and removes the remaining stragglers. Signed-off-by: Jason A. Donenfeld <[email protected]>
1 parent 9a29ae2 commit f9dac70

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

device/noise-protocol.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020

2121
type handshakeState int
2222

23-
// TODO(crawshaw): add commentary describing each state and the transitions
2423
const (
2524
handshakeZeroed = handshakeState(iota)
2625
handshakeInitiationCreated

device/send.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ func (peer *Peer) RoutineSequentialSender() {
421421
// This is an optimization only. It is possible for the peer to be stopped
422422
// immediately after this check, in which case, elem will get processed.
423423
// The timers and SendBuffer code are resilient to a few stragglers.
424-
// TODO(josharian): rework peer shutdown order to ensure
424+
// TODO: rework peer shutdown order to ensure
425425
// that we never accidentally keep timers alive longer than necessary.
426426
device.PutMessageBuffer(elem.buffer)
427427
device.PutOutboundElement(elem)

tun/tuntest/tuntest.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func (t *chTun) File() *os.File { return nil }
113113
func (t *chTun) Read(data []byte, offset int) (int, error) {
114114
select {
115115
case <-t.c.closed:
116-
return 0, io.EOF // TODO(crawshaw): what is the correct error value?
116+
return 0, os.ErrClosed
117117
case msg := <-t.c.Outbound:
118118
return copy(data[offset:], msg), nil
119119
}
@@ -130,7 +130,7 @@ func (t *chTun) Write(data []byte, offset int) (int, error) {
130130
copy(msg, data[offset:])
131131
select {
132132
case <-t.c.closed:
133-
return 0, io.EOF // TODO(crawshaw): what is the correct error value?
133+
return 0, os.ErrClosed
134134
case t.c.Inbound <- msg:
135135
return len(data) - offset, nil
136136
}

0 commit comments

Comments
 (0)