Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit 5d0fdd6

Browse files
Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=218254 Reviewed by Joseph Pecoraro. r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that `WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`. * UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView.prototype._domTreeElementAdded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@269071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 4f1a6ea commit 5d0fdd6

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

Source/WebInspectorUI/ChangeLog

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
2020-10-27 Devin Rousso <[email protected]>
2+
3+
Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
4+
https://bugs.webkit.org/show_bug.cgi?id=218254
5+
6+
Reviewed by Joseph Pecoraro.
7+
8+
r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that
9+
`WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`.
10+
11+
* UserInterface/Views/DOMTreeContentView.js:
12+
(WI.DOMTreeContentView.prototype._domTreeElementAdded):
13+
114
2020-10-26 Devin Rousso <[email protected]>
215

316
Web Inspector: console command line API should be exposed to breakpoint conditions/actions

Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ WI.DOMTreeContentView = class DOMTreeContentView extends WI.ContentView
500500
if (!this._pendingBreakpointNodes.delete(node))
501501
return;
502502

503-
this._updateBreakpointStatus(node.id);
503+
this._updateBreakpointStatus(node);
504504
}
505505

506506
_domTreeSelectionDidChange(event)

0 commit comments

Comments
 (0)