Web Inspector: Search: don't steal focus from the search field when shown

https://bugs.webkit.org/show_bug.cgi?id=218260

Reviewed by Brian Burg.

* UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel.prototype.focusSearchField):
(WI.SearchSidebarPanel.prototype.performSearch.createTreeElementForMatchObject):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@269074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebInspectorUI/ChangeLog

@@ -1,3 +1,14 @@
+2020-10-27  Devin Rousso  <[email protected]>
+
+        Web Inspector: Search: don't steal focus from the search field when shown
+        https://bugs.webkit.org/show_bug.cgi?id=218260
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WI.SearchSidebarPanel.prototype.focusSearchField):
+        (WI.SearchSidebarPanel.prototype.performSearch.createTreeElementForMatchObject):
+
 2020-10-27  Devin Rousso  <[email protected]>
 
         Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)

Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js

@@ -93,10 +93,10 @@ WI.SearchSidebarPanel = class SearchSidebarPanel extends WI.NavigationSidebarPan
         this._inputElement.select();
 
         if (performSearch)
-            this.performSearch(this._inputElement.value);
+            this.performSearch(this._inputElement.value, {omitFocus: true});
     }
 
-    performSearch(searchQuery)
+    performSearch(searchQuery, {omitFocus} = {})
     {
         this._inputElement.value = searchQuery;
         this._searchQuerySetting.value = searchQuery;
@@ -141,7 +141,7 @@ WI.SearchSidebarPanel = class SearchSidebarPanel extends WI.NavigationSidebarPan
             createSearchingPlaceholder();
             WI.whenTargetsAvailable().then(() => {
                 if (this._searchQuerySetting.value === searchQuery)
-                    this.performSearch(searchQuery);
+                    this.performSearch(searchQuery, {omitFocus});
             });
             return;
         }
@@ -176,8 +176,10 @@ WI.SearchSidebarPanel = class SearchSidebarPanel extends WI.NavigationSidebarPan
 
             parentTreeElement.appendChild(matchTreeElement);
 
-            if (!this.contentTreeOutline.selectedTreeElement)
-                matchTreeElement.revealAndSelect(false, true);
+            if (!this.contentTreeOutline.selectedTreeElement) {
+                const selectedByUser = true;
+                matchTreeElement.revealAndSelect(omitFocus ?? false, selectedByUser);
+            }
         }
 
         function forEachMatch(lineContent, callback)