Skip to content

Commit 9004a09

Browse files
committed
fix firmware parsing
1 parent 93e2ed7 commit 9004a09

File tree

6 files changed

+26
-16
lines changed

6 files changed

+26
-16
lines changed

DataStructures/data.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Data:
3838
Version Updater
3939
'''
4040
lastChecked = -1
41-
pyInstallCurrentVersion = 0.912
41+
pyInstallCurrentVersion = 0.913
4242
pyInstallUpdateAvailable = False
4343
pyInstallUpdateBrowserUrl = ""
4444
pyInstallUpdateVersion = 0

WebPageProcessor/webPageProcessor.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,12 @@ def createWebPage(self, pageID, isMobile, args):
484484
)
485485
return page, "Open Board", False, "medium", "content", "footerSubmit"
486486
elif pageID == "about":
487+
version = self.data.pyInstallCurrentVersion
487488
if isMobile:
488489
pageName = "about.html"
489490
else:
490491
pageName = "about.html"
491-
page = render_template(pageName, pageID="about")
492+
page = render_template(pageName, pageID="about", version=version)
492493
return page, "About", False, "medium", "content", False
493494
elif pageID == "gettingStarted":
494495
if isMobile:

config/config.py

+18-6
Original file line numberDiff line numberDiff line change
@@ -597,18 +597,30 @@ def parseFirmwareVersions(self):
597597
path = home+"/firmware/madgrizzle/*.hex"
598598
for filename in glob.glob(path):
599599
version = filename.split("-")
600-
version = version[1].split(".hex")
601-
self.data.customFirmwareVersion = version[0]
600+
maxIndex = len(version)-1
601+
if maxIndex >= 0:
602+
version = version[maxIndex].split(".hex")
603+
self.data.customFirmwareVersion = version[0]
604+
else:
605+
self.data.customFirmwareVersion = "n/a"
602606
path = home+"/firmware/maslowcnc/*.hex"
603607
for filename in glob.glob(path):
604608
version = filename.split("-")
605-
version = version[1].split(".hex")
606-
self.data.stockFirmwareVersion = version[0]
609+
maxIndex = len(version)-1
610+
if maxIndex >= 0:
611+
version = version[maxIndex].split(".hex")
612+
self.data.stockFirmwareVersion = version[0]
613+
else:
614+
self.data.stockFirmwareVersion = "n/a"
607615
path = home+"/firmware/holey/*.hex"
608616
for filename in glob.glob(path):
609617
version = filename.split("-")
610-
version = version[1].split(".hex")
611-
self.data.holeyFirmwareVersion = version[0]
618+
maxIndex = len(version)-1
619+
if maxIndex >= 0:
620+
version = version[maxIndex].split(".hex")
621+
self.data.holeyFirmwareVersion = version[0]
622+
else:
623+
self.data.holeyFirmwareVersion = "n/a"
612624

613625
def processChange(self, key, value):
614626
### TODO: This does not currently fire on bools ##

main.py

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import os
88

99

10-
1110
monkey.patch_all()
1211

1312
import schedule

templates/about.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="card">
55
<div class="card-body">
66
<h2>WebControl</h2>
7-
<p>Version 0.904</p>
7+
<p>Version v{{version}}</p>
88
<h4 class="mt-0 mb-2">Webcontrol is licensed under the&nbsp;GNU General Public License v3.0</h4>
99
<p class="mb-0 text-gray text-small pr-2">Permissions of this strong copyleft license are conditioned on making available complete source code of licensed works and modifications, which include larger works using a licensed work, under the same license. Copyright and license notices must be preserved. Contributors provide an express grant of patent rights.</p>
1010
<p class="mb-0 text-gray text-small pr-2"><a href="https://www.github.com/madgrizzle/webcontrol">https://www.github.com/madgrizzle/webcontrol</a></p>

templates/actions.html

+4-6
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
<div class="card">
1616
<div class="card-body">
1717
<h4 class="card-title">Diagnostics/Maintenance</h4>
18-
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('returnToCenter');$('#contentModal').modal('hide');">Return to Center</button>
19-
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('resetChainLengths');$('#contentModal').modal('hide');">Reset Chain Lengths</button>
20-
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('moveToDefault');$('#contentModal').modal('hide');">Move to Default Location</button>
2118
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('testMotors');$('#contentModal').modal('hide');">Test Motors/Encoders</button>
2219
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('queryCamera');$('#contentModal').modal('hide');">Query Camera</button>
2320
<a class="btn btn-lg btn-block btn-secondary" href="downloadDiagnostics?rnd=1" onClick="this.href=this.href.split('?')[0]+'?rnd='+new Date().getTime()" target="_blank">Download Diagnostics File</a>
@@ -26,8 +23,6 @@ <h4 class="card-title">Diagnostics/Maintenance</h4>
2623
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('clearLogs');$('#contentModal').modal('hide');">Clear Log Files</button>
2724
<button type="button" class="btn btn-lg btn-block btn-danger" onclick="action('shutdown');$('#contentModal').modal('hide');">{{'Shutdown WebControl/WebMCP' if docker else 'Shutdown WebControl'}}</button>
2825
<button type="button" class="btn btn-lg btn-block {{'btn-primary' if updateAvailable else 'btn-secondary'}}" onclick="action('updatePyInstaller');$('#contentModal').modal('hide');" {{'' if updateAvailable else 'disabled'}}>Update WebControl: {{updateRelease}}</button>
29-
30-
3126
</div>
3227
</div>
3328
</div>
@@ -42,7 +37,9 @@ <h4 class="card-title">Calibration/Setup</h4>
4237
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="requestPage('triangularCalibration');$('#contentModal').modal('hide');">Triangular Calibration</button>
4338
<button type="button" class="btn btn-lg btn-block btn-secondary" {{'' if enableCustom else 'data-toggle="tooltip" title="Custom Firmware Required"' | safe}} onclick="requestPage('opticalCalibration');$('#contentModal').modal('hide');" {{'' if enableCustom else 'disabled'}}>Optical Calibration</button>
4439
<button type="button" class="btn btn-lg btn-block btn-secondary" {{'' if enableHoley else 'data-toggle="tooltip" title="Holey Firmware Required"' | safe}} onclick="requestPage('holeyCalibration');$('#contentModal').modal('hide');" {{'' if enableHoley else 'disabled'}}>Holey Calibration</button>
45-
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="requestPage('pidTuning');$('#contentModal').modal('hide');">PID Tuning</button>
40+
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('returnToCenter');$('#contentModal').modal('hide');">Return to Center</button>
41+
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('resetChainLengths');$('#contentModal').modal('hide');">Reset Chain Lengths</button>
42+
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('moveToDefault');$('#contentModal').modal('hide');">Move to Default Location</button>
4643
</div>
4744
</div>
4845
</div>
@@ -57,6 +54,7 @@ <h4 class="card-title">Controller</h4>
5754
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('wipeEEPROM','Settings');$('#contentModal').modal('hide');">Wipe Controller Settings</button>
5855
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('wipeEEPROM','Maslow');$('#contentModal').modal('hide');">Wipe Controller Positional Data</button>
5956
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="action('wipeEEPROM','All');$('#contentModal').modal('hide');">Wipe Controller EEPROM</button>
57+
<button type="button" class="btn btn-lg btn-block btn-secondary" onclick="requestPage('pidTuning');$('#contentModal').modal('hide');">PID Tuning (Advanced)</button>
6058
</div>
6159
</div>
6260
</div>

0 commit comments

Comments
 (0)