Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Waybar from hiding. #2585

Open
AgostinoA opened this issue Feb 21, 2025 · 10 comments
Open

Prevent Waybar from hiding. #2585

AgostinoA opened this issue Feb 21, 2025 · 10 comments
Labels

Comments

@AgostinoA
Copy link

AgostinoA commented Feb 21, 2025

Describe the bug
I've been going crazy for days and can't figure out how this issue started. I updated both Wayfire to the latest version and Waybar, and from that moment on, this problem appeared: when I open a fullscreen app, especially with Wine, Waybar leaves an empty space in the bar area and doesn't go fully fullscreen.

I'm not sure if it's an IPC request timing issue or something else. However, if I toggle fullscreen on and off from within the game, it works correctly.

Additionally, in some games like Crysis 2, all mouse position events become misaligned, making the cursor behave erratically.

To Reproduce

  1. Open a game in fullscreen.

Expected behavior
I expect that any app running in fullscreen should cover the entire screen and that mouse input should remain accurate.

Screenshots or stacktrace

Image

Image

Wayfire version
git

@AgostinoA AgostinoA added the bug label Feb 21, 2025
@soreau
Copy link
Member

soreau commented Feb 21, 2025

It might be 7889960 causing the problem. Does the commit before this one work ok?

@AgostinoA
Copy link
Author

AgostinoA commented Feb 21, 2025

Yes, it did that before that change too.

@AgostinoA
Copy link
Author

I found a report from another user experiencing the same issue on Waybar:
[Waybar Issue #3387](Alexays/Waybar#3387).
Now, I'm not sure if the issue is caused by Wayfire or Waybar. 😅

@soreau
Copy link
Member

soreau commented Feb 21, 2025

Maybe check if wf-panel does the same thing.

@CarloWood
Copy link
Contributor

"Waybar leaves an empty space in the bar area and doesn't go fully fullscreen."
You want waybar to go full screen?

@AgostinoA
Copy link
Author

I want the empty space not to remain

@AgostinoA
Copy link
Author

AgostinoA commented Feb 22, 2025

Maybe check if wf-panel does the same thing.

Same problem, even with wf-panel. I created a simple fullscreen screen using GLFW.
Check if it happens to you as well, because I can't figure out if it's only on my configurations or something else.
Image

I'm also uploading the code for a test.

#include <GLFW/glfw3.h>

int main() {
    if (!glfwInit()) return -1;

    GLFWmonitor* primaryMonitor = glfwGetPrimaryMonitor();
    const GLFWvidmode* mode = glfwGetVideoMode(primaryMonitor);

    glfwWindowHint(GLFW_RED_BITS, mode->redBits);
    glfwWindowHint(GLFW_GREEN_BITS, mode->greenBits);
    glfwWindowHint(GLFW_BLUE_BITS, mode->blueBits);
    glfwWindowHint(GLFW_REFRESH_RATE, mode->refreshRate);

    GLFWwindow* window = glfwCreateWindow(mode->width, mode->height, "Fullscreen Red", primaryMonitor, nullptr);
    if (!window) {
        glfwTerminate();
        return -1;
    }

    glfwMakeContextCurrent(window);

    while (!glfwWindowShouldClose(window)) {
        glClearColor(1.0f, 0.0f, 0.0f, 1.0f);
        glClear(GL_COLOR_BUFFER_BIT);
        
        glfwSwapBuffers(window);
        glfwPollEvents();
    }

    glfwDestroyWindow(window);
    glfwTerminate();
    return 0;
}

@ammen99 Can you support me with this? Sorry for the trouble.

@AgostinoA
Copy link
Author

AgostinoA commented Feb 24, 2025

@CarloWood and @soreau, but do you have this problem?

@ammen99
Copy link
Member

ammen99 commented Feb 24, 2025

@AgostinoA thanks for your glfw example, I can reproduce the issue. Will look into it and let you know when a bug fix is available.

@AgostinoA
Copy link
Author

AgostinoA commented Feb 24, 2025

@ammen99 It's a real pleasure for me. I'm here to find as many bugs as possible and give support to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants