Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message of the day When editing, a picture loses its size. #9838

Open
eitanwa opened this issue Jan 26, 2025 · 30 comments
Open

Message of the day When editing, a picture loses its size. #9838

eitanwa opened this issue Jan 26, 2025 · 30 comments
Labels

Comments

@eitanwa
Copy link

eitanwa commented Jan 26, 2025

hey daniel
How are you?

When editing the message the image loses its size

Set new message
Set the image to the desired size
Save
Click edit again (no need to make any changes) and save

Image

After editing

Image

thanks daniek

@eitanwa eitanwa added the bug label Jan 26, 2025
@DanielnetoDotCom
Copy link
Member

Probably you are using an image that is too big,
you should review how you add images on it

@eitanwa
Copy link
Author

eitanwa commented Jan 28, 2025

Probably you are using an image that is too big, you should review how you add images on it

I changed the size to 99%
and that's fine
but as soon as I click on edit
it loses the size that was set

U can see it here

Image

This editor is the same one as in the articles, right?

this shows better

motd.mp4

@DanielnetoDotCom
Copy link
Member

Where did you change the size?

change in the HTML editor is not change the image size.

change the size requires something like photoshop or other image tool

the images on your page should alway be in the original size

@eitanwa
Copy link
Author

eitanwa commented Jan 28, 2025

I change the image size in the HTML editor
The editor allows this
This is a screenshot from the plugin editor.
Image

This is what I show in the video
Just like I do in the editor in articles or in the editor found in the top menue plugin
I thought this editor would also allow this
Actually it allows it but does not save the edit

@DanielnetoDotCom
Copy link
Member

but this is not resize image.

but is up to you. this is not the write way. you will have a lot of benefits doing in the right way.

If I am in your shoes I would google or AI for that benefits.

@eitanwa
Copy link
Author

eitanwa commented Jan 28, 2025

Okay, I completely lost you
I have a question
In the plugin itself there are two places where you can edit a message
Shown in the screenshot

Image

Image

If you were talking about the first option I would understand

The question is this:
Everything you wrote referred to the two places where you can edit a message?

@guymass
Copy link
Contributor

guymass commented Jan 29, 2025

@DanielnetoDotCom I think @eitanwa is trying to understand what is the right way to edit this message and why in one of those ways it will not save the changes made to the image? Why that particular editor will not save the edited images?

@guymass
Copy link
Contributor

guymass commented Jan 29, 2025

In the Message of the day editor, when trying to save an image dimensions, the editor will not save them or will reset those parameters when you click the edit button. We would like the image to remain as we set it when we open that message to edit it again. Something is causing the editor to reset the image dimensions to the original size.

@DanielnetoDotCom
Copy link
Member

staticGlobalMessageTitle wil be a message that will show once a day every day.

@guymass
Copy link
Contributor

guymass commented Feb 2, 2025

Hi Daniel, I still have an annoying issue with the main Message Of The Day plugin.

When I use the editor I want to write some text and add an image. As I understand this turns to HTML and the parameters of the image namely Width and Height are entered in the following screenshot:

Image

My issue is that those parameters are being reset to original image size. Even after I set to a smaller dimensions, if I edit the message and than click again the Save button, the image size doesn't save my selected dimensions.

If the image was 1024 x 800 and I reduced to 320 x 240, First save looks ok, than I edit the message and save again, the image will reset back to 1024 x 800, forgetting my previous save.

@eitanwa
Copy link
Author

eitanwa commented Feb 2, 2025

I will also try to clarify
because I am sure there is a misunderstanding here
So it's worth making one last attempt.

When editing the image size (in the editor itself)
The image will be displayed in the desired size
This works as expected The ad will be displayed to users for the entire day as set in the target date
So far everything is fine
I set the image width to 99%
Results

Image

Image

When editing the same ad
For example changing the date, text or any other detail
The image will return to its original size and it is necessary to edit the size again

p.s
It is enough to click Edit and Save
There is no need to necessarily make a change in the actual

Results

Image

Image

@JoshWho
Copy link
Contributor

JoshWho commented Feb 3, 2025

Now I have a user that is saying she wanted her image file to shrink and lately it just stopped.


"
Huntress in the Flood chat just now: Huntress
My AI makes high quality, high resolution images. FTJ should just auto resize them on upload, it did, now it doesn't.
"

@eitanwa
Copy link
Author

eitanwa commented Feb 3, 2025

Okay now I'm 100% sure the problem is with the tiny writer

When manually resizing the image even slightly

Untitled.video.-.Made.with.Clipchamp.4.mp4

the size will remain as expected

@JoshWho @guymass

p.s
Is there an option to upgrade tiny to the full version?

I must tell you that over the last 5 years I have used this editor a lot to create Dozens of pages including changing file sizes
I usually set the width to 99% and height 0 which is also good for mobile
Other sizes I use tables
And other amazing things
You wrote that we cannot change file size in this editor
And it is necessary to use an image editor for that
I really lost you here

However, using this editor is a significant addition to this perfect system
And I saw that the full version also has AI options
So if there is a way I would personally be happy
Is there a need for an additional payment for this? How much?
Thanks Daniel

@JoshWho
If you also allow your users to edit images
I recommend you check how it looks on mobile
Not using percentages/tables
Distorts the proportion on mobile web

I'm almost certain the upgrade has
Mobile Site Compatibility

@DanielnetoDotCom
Copy link
Member

@eitanwa I tried many times reprduce the image issue locally. but here works fine

can you please reproduce it on demo site?

@eitanwa
Copy link
Author

eitanwa commented Feb 3, 2025

@eitanwa I tried many times reprduce the image issue locally. but here works fine

can you please reproduce it on demo site?

How can I do this if I don't have editing access in the plugin?

@DanielnetoDotCom
Copy link
Member

https://demo.avideo.com/

user: admin
pass: 123

@eitanwa
Copy link
Author

eitanwa commented Feb 9, 2025

Hi Daniel
Yes, the same here
If you need another screenshot or video beyond that

Image

Tell me, I'll try to think of how to illustrate it for you

@DanielnetoDotCom
Copy link
Member

where is it?

I just went there and I did not see the message?
maybe is too late and it is overwritten.
I just tested again and it works as expected.

did you resize the image?

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

Hi, this is a screenshot from the Message of the Day plugin

-I deleted it after taking the screenshot

-Yes, once you change the size manually, only then The size of the image remian

-If you do this by setting parameters, the size will not remain fixed

*That's why I asked you how to illustrate this for you?

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

Would you like me to create an ad again?

@DanielnetoDotCom
Copy link
Member

yes create it

and what do you mean "If you do this by setting parameters,"

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

i did

what i mean is that
resize image with this

Image

doesnt work as suppse to doesnt save the new parameters
only after u resize it "Manually" by reducing the file size
Drag to reduce and enlarge

Image

then you can change the parameters using the interface shown in the first image

@DanielnetoDotCom
Copy link
Member

I see what you mean now. drag and drop works, but add the numbers in the box does not work

But why is it a big deal? why dont you drag and drop it?

@DanielnetoDotCom
Copy link
Member

BTW, I also just tested changing the values in the box and all still file on my side

Image

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

You are right as long as I am aware of it it doesn't really matter
The thing is
The same bug also exists in other places where
The Text editor is found for example in articles, and in the top menu

And in places where users also have access such as articles
This is what josh wrote to you
#9838 (comment)

This could be a big problem in breaking the site as you say before

I work a lot with this text editor
to modify images and files and build pages
and it's great
as you can see it's such a tricky bug that it's hard to explain
and it appears in more places I thought it should be fixed

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

BTW, I also just tested changing the values in the box and all still file on my side

If you have changed once using drag and drop
changing parameters will always work -save
if you haven't
it won't work -save

@DanielnetoDotCom
Copy link
Member

Understood, but I still cannot reproduce it

check my last comment

I still do not understand how to reproduce it

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

Understood, but I still cannot reproduce it

check my last comment

I still do not understand how to reproduce it

Sorry I probably don't understand the expression reproduce
Up until now when you asked me to do so
I checked your site and I told you that there is the same problem there too
I thought that was what you meant by reproduce
If you could clarify this please

@DanielnetoDotCom
Copy link
Member

I need to be able to reproduce the issue by myself, you need to guide me in a way this will also happen with me

for now, everytime I tried works with no problem

@eitanwa
Copy link
Author

eitanwa commented Feb 10, 2025

I need to be able to reproduce the issue by myself, you need to guide me in a way this will also happen with me

for now, everytime I tried works with no problem

go to the messege i uploded
Scroll right to reach the Edit button.
press edit

set the image on width 99% (not by drag and drop)
save
just press edit again
and save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants