Language String Translation doesn't translate my strings

[guymass]

I have several titles on site which do not translate when I edit en_US.php and he_IL.php to translate my strings from English to Hebrew.

Some of my titles are Category Names which also do not translate. So my home page has like a mix of Hebrew and English titles which I want to fix on the Hebrew language.

I have tested on two sites and on both translation doesn't work.

Example of the English strings for translation set in en_US.php:

$t['Friend Request Sent, Awaiting Approval'] = 'Friend Request Sent, Awaiting Approval';
$t['Shorts'] = 'Shorts';
$t['Send Friend Request'] = 'Send Friend Request';
$t['Remove first page'] = 'Remove first page';
$t['view more'] = 'view more';
$t['Most Recent'] = 'Most Recent';
$t['Science and Technology'] = 'Science and Technology';
$t['playlists'] = 'playlists';
$t['culture-and-arts'] = 'culture-and-arts';
$t['Articles'] = 'Articles';
$t['News'] = 'News';
$t['books'] = 'books';

Hebrew translations set in he_IL.php:

$t['Friend Request Sent, Awaiting Approval'] = 'בקשת חברות נשלחה, ממתין לאישור';
$t['Shorts'] = 'קצרים';
$t['Send Friend Request'] = 'שליחת בקשת חברות';
$t['Remove first page'] = 'הסר מדף ראשי';
$t['view more'] = 'קרא עוד';
$t['Most Recent'] = 'התווסף לאחרונה';
$t['Science and Technology'] = 'טכנולוגיה ומדעים';
$t['playlists'] = 'פלייליסטים';
$t['culture-and-arts'] = 'תרבות ואומנות';
$t['Articles'] = 'מאמרים';
$t['News'] = 'חדשות';
$t['books'] = 'ספרים';

After clearing cache several times and refreshing nothing seems to change at all:

[DanielnetoDotCom]

This is a category menu that you created.
there are this translation somewhere on the site or is only not translating in the category menu?

[guymass]

Yes we are using the categoriesTopButtons menu option to display the categories.

I have noticed also trying to translate the "Most Recent" video category will not take my translation.

Here are some of the thing that do not translate:

[DanielnetoDotCom]

Please separate the issues, not there are multiple issues in this thread

[DanielnetoDotCom]

I am not sure what you are doing in the translation, but I have added the translation as it supposed to be in the file (copy from your post)

and I can see it translated.

[guymass]

I explained what I was doing, just like you I added the strings and their translations in both language files and than I cleared the cache expecting to see it translated but it don't do it on both my sites, IDK.

[DanielnetoDotCom]

check it here 3b987b3

[guymass]

Sorry I don't understand what to check? it appears to be an he_IL.php file. Not sure what you want me to do.

[DanielnetoDotCom]

Just check what I did, so next time you can do the same.

[guymass]

I have done this many times before and it was working just fine, but I haven't translated anything in recent couple of month and only after several updates I decided to translate, finding out it doesn't work for me. Here is how my two files look:

I moved all new strings to the bottom of the file and still it doesn't recognize them. Maybe it will only work on git pull from the master e.g. from you? im not sure really what could be the problem.

[DanielnetoDotCom]

When you make a translation you may want to make a pull request, so I can check it from my side.

[guymass]

But I don't have a branch setup, how do I make the pull request?

[DanielnetoDotCom]

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

[guymass]

Sorry, this is too confusing for me and I don't want to mess up things on my server. Do I need to create a fork first? how do I add my own server directory so when I commit changes and make a pull request is goes from my own server to the main branch?

Currently I only make pull requests and I never made a fork, plus I am not sure how to make one from command line as I am not that familiar with git.

Anyway which is simpler?

[guymass]

Do I create a fork and then I switch my site and set it to point to my fork? then when I make git pulls or pull requests it goes from the forked git to the main?

Or is it more like me updating the main through my forked branch and then I keep my site still pulling from the master branch, so I don't need to make any changes on my server.

[DanielnetoDotCom]

In other word, you can have a fork and alway ask git to sync mine and your fork

when you send your changes to mine it is a pull request (I may approve or not)

[guymass]

I noticed not I have an old fork named guymass/AVideo which I just synced and updated with the master, so I will try to make the pull requests using it. Please let me know when you receive the requests so I know it is working.

[DanielnetoDotCom]

That explain your other issues

[guymass]

I just now sent two commits regarding the Hebrew translation.

Don't understand what you meant with "That explain your other issues". What are you referring to? The hard reset?

[DanielnetoDotCom]

This #9765

and this #9767

you are not updating the code properly

[DanielnetoDotCom]

There are no pull request on my side

[guymass]

So to which branch did I not sent those requests? You see why this git hub confuses me.

It also says:

[guymass]

Do you see it now?

[eitanwa]

Hi Daniel, maybe this matter is also related to this?
#9760
#9760 (comment)

[DanielnetoDotCom]

@eitanwa maybe yes

[DanielnetoDotCom]

@guymass I can see the pull request now, I will review it later

[eitanwa]

@eitanwa maybe yes

Let's hope so
This is a long article :)

[guymass]

OK I finally got the git branch sorted out, just in case someone has the same issue its important to use this command:

git checkout master

than do a git pull.

I see some of my translations are now working again so I will close this issue and wait for you to approve my pull requests. I think it will work now.

[guymass]

Hi Daniel, I still for some reason have problem translating strings to Hebrew. Here are some of the string in screenshots.

Also notice that most of those strings are made by you and are part of the main system and should have a translation.
I checked the language files and those strings are not in them.

What can I do to force the translation? or how can I check the log to locate translation issues?

[DanielnetoDotCom]

Is this a custom menu?

the problem is for now I cannot translate your assets.

I can only translate the global avideo assets.

I may add something in the future for a custom translation

[guymass]

Well that's fine and will be most helpful. But for now title such as the followings are I think belong to avideo assets:

Custom ADs
Videos History
Support
Templates
Connect Mobile App

I think those are required, I don't think we created those titles.

Also I always had the ability to translate the names of menus and categories I created, so what has changed? If I create a category in my own language, shouldn't I be able to provide translation using the language files? otherwise what is the point? because AVideo sites will always have these issues no being able to fully be a multi language site. There will always be an issue of foreign language strings not being translated for custom created menus and categories etc.

I think this is important to at least allow the support on menus and categories names and anything that relates to the UI.

[DanielnetoDotCom]

1. Titles such as "Custom ADs," "Videos History," "Support," "Templates," and "Connect Mobile App":
   These titles are part of the standard AVideo UI. If they are not translating as expected, it might indicate that the relevant entries are either missing from the language files or require a code update.

2. Translating Menus and Categories:

   • For any new categories or menus you create in your environment, AVideo is not yet ready to support translation for these custom additions. However, we recognize the importance of this feature and may add this functionality in the future.
   • Currently, AVideo supports approximately 99% translatability, with 95% of the text strings already included in the language files.
   • Some translations may be prepared but not yet present in the language files.

3. Identifying Missing Translations:
   To determine which translations are missing or not functioning as expected:

   • Check the language file to confirm if the text exists.
   • If the text exists but does not translate, this indicates that a code update is required.

4. Next Steps to Resolve Issues:

   • For existing UI strings that are not translating, please provide screenshots of the specific area. This will help identify the location in the code that requires updating.
   • For new menus or categories you create, please note that they currently cannot be translated through the language files. I will keep this in mind for future enhancements to the platform.

[guymass]

Thank you for the info and good clarification of the translation process. I am sure you will handle it when the time is right.
Please do so a code update for the following string as they do not translate on my Hebrew template:

"Custom ADs," "Videos History," "Support," "Templates," and "Connect Mobile App":

Also the Menu Headings are missing translation, so whatever you can translate from this section would be helpful for us to have a more concise UI experience.

Also if you need I can give you the Hebrew translations to Copy/Paste for whichever strings you approve of.

[guymass]

This should also be translated.

[DanielnetoDotCom]

Hi

add the translation to the hebrew file then submit a pull request, then I can test from my side why it is not translating.

Do not pull request your personal translations

[guymass]

I just sent you a pull request. I set the specific strings to be the top most 10 lines on both language files, US and IL. Please review them and check why they are not translating for me.

[DanielnetoDotCom]

Approved, and I have the same version as you. what part you are seeing missing translations?

[guymass]

These are the strings that still don't translate:

[guymass]

I managed now to translate "Videos History" Successfully. I will check maybe the other string will work now as well.

I also was able to translate the category art-and-culture, but I changed it to Art and Culture.

• translations will not translate strings with '-' dash.
  Also was able now to translate "Photo gellery", it seems that when using multiple words they must have a Capital first letter. When changing it to "Photo Gellery" I was able to make the translation work.

I am writing these here so others will know what to take into consideration.

[DanielnetoDotCom]

Please take a moment to carefully read the details provided below. It's important to ensure we are on the same page to avoid unnecessary delays in resolving your issues.

I recommend reviewing this link:
#9763 (comment)

This link explains important points, including:

1. Custom menus or features you create in your environment (e.g., "Most Recent," "Create Live Conference," "Statements/Policy," "Help Center") are not part of the AVideo core code, and therefore, are not managed by me.
2. Features like "Videos History" or "Connect Mobile App" are not in the current translation files. You can verify this by checking the language files yourself.

Key points from the link:

• Custom menus or categories you add cannot currently be translated through the language files.
• If a text string from the standard UI is missing from the translation, it might require an update to the language files or the code itself.

[guymass]

OK I was finally able to translate all my strings and now everything looks great on RTL/ Much thanks for all the help, interface looks awesome as well. I am closing this post.