Skip to content

Commit 3008368

Browse files
huydhnpytorchmergebot
authored andcommitted
Honor Dr.CI classification results on auto commit hash update (pytorch#146337)
Disable `ignore_flaky_failures` was a safer choice, but it seems that this option doesn't work with the current state of the CI. For example, pytorch#125806 hasn't been merged since May because there would always be a failure in one type or another. This effectively disables the automate mechanism. My proposal here is to relax this rule and allows the bot to merge auto commit has update with `@pytorchbot merge` like a regular PR. Then we will at least have something working. If this causes issue, we can revert it back and try to longer route of improving CI reliability. Pull Request resolved: pytorch#146337 Approved by: https://github.com/clee2000
1 parent 44b69b8 commit 3008368

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

.github/merge_rules.yaml

-3
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
- .ci/docker/ci_commit_pins/triton.txt
8080
approved_by:
8181
- pytorchbot
82-
ignore_flaky_failures: false
8382
mandatory_checks_name:
8483
- EasyCLA
8584
- Lint
@@ -91,7 +90,6 @@
9190
- test/slow_tests.json
9291
approved_by:
9392
- pytorchbot
94-
ignore_flaky_failures: false
9593
mandatory_checks_name:
9694
- EasyCLA
9795
- Lint
@@ -103,7 +101,6 @@
103101
- .ci/docker/ci_commit_pins/executorch.txt
104102
approved_by:
105103
- pytorchbot
106-
ignore_flaky_failures: false
107104
mandatory_checks_name:
108105
- EasyCLA
109106
- Lint

0 commit comments

Comments
 (0)