VC-3299 fix php fatal error with enviroment without wp_filesystem and php 8.0+ version

Author: OlegApanovich

visualcomposer/Helpers/File.php

@@ -26,29 +26,55 @@ public function getContents($filePath)
             return false;
         }
 
+        $fileSystem = $this->getFileSystem();
+        if (!$fileSystem) {
+            return false;
+        }
+
         // get content from using file system
-        return $this->getFileSystem()->get_contents($filePath);
+        return $fileSystem->get_contents($filePath);
     }
 
     public function exists($filePath)
     {
-        return $this->getFileSystem()->exists($filePath);
+        $fileSystem = $this->getFileSystem();
+        if (!$fileSystem) {
+            return false;
+        }
+
+        return $fileSystem->exists($filePath);
     }
 
     public function isFile($filePath)
     {
-        return $this->getFileSystem()->is_file($filePath);
+        $fileSystem = $this->getFileSystem();
+        if (!$fileSystem) {
+            return false;
+        }
+
+        return $fileSystem->is_file($filePath);
     }
 
     public function isDir($filePath)
     {
-        return $this->getFileSystem()->is_dir($filePath);
+        $fileSystem = $this->getFileSystem();
+        if (!$fileSystem) {
+            return false;
+        }
+
+        return $fileSystem->is_dir($filePath);
     }
 
     public function rename($oldName, $newName)
     {
         $this->checkDir(dirname($newName));
-        return $this->getFileSystem()->move($oldName, $newName);
+
+        $fileSystem = $this->getFileSystem();
+        if (!$fileSystem) {
+            return false;
+        }
+
+        return $fileSystem->move($oldName, $newName);
     }
 
     /**
@@ -60,8 +86,14 @@ public function rename($oldName, $newName)
     public function setContents($filePath, $contents)
     {
         $this->checkDir(dirname($filePath));
+
+        $fileSystem = $this->getFileSystem();
+        if (!$fileSystem) {
+            return false;
+        }
+
         // set content using file system
-        return $this->getFileSystem()->put_contents($filePath, $contents);
+        return $fileSystem->put_contents($filePath, $contents);
     }
 
     /**
@@ -99,12 +131,17 @@ public function unzip($file, $destination, $overwrite = false)
     }
 
     /**
+     * Get wp filesystem object.
+     *
+     * @note we always should check if we have access to filesystem before ise it.
+     *
      * @return \WP_Filesystem_Base|bool
      */
     public function getFileSystem()
     {
         // @codingStandardsIgnoreLine
         global $wp_filesystem;
+
         $status = true;
         // @codingStandardsIgnoreLine
         if (!$wp_filesystem || !is_object($wp_filesystem)) {

visualcomposer/Modules/Assets/FileController.php

@@ -124,8 +124,9 @@ protected function parseGlobalElementsCssFile(
         if ($bundleUrl) {
             if (!empty($previousCssFile) && empty($previousCssHash)) {
                 $assetsPath = $assetsHelper->getFilePath($previousCssFile);
-                if (!empty($assetsPath)) {
-                    $fileHelper->getFileSystem()->delete($assetsPath);
+                $fileSystem = $fileHelper->getFileSystem();
+                if ($fileSystem && !empty($assetsPath)) {
+                    $fileSystem->delete($assetsPath);
                 }
             }
         }

visualcomposer/Modules/Migrations/Assets22Migration.php

@@ -68,10 +68,13 @@ protected function moveFiles(File $fileHelper, Options $optionsHelper)
             true
         );
         if (!is_wp_error($result) && $result) {
-            $resultMove = $fileHelper->getFileSystem()->move(
-                VCV_PLUGIN_ASSETS_DIR_PATH . '-temp',
-                VCV_PLUGIN_ASSETS_DIR_PATH
-            );
+            $fileSystem = $fileHelper->getFileSystem();
+            if ($fileSystem) {
+                $resultMove = $fileSystem->move(
+                    VCV_PLUGIN_ASSETS_DIR_PATH . '-temp',
+                    VCV_PLUGIN_ASSETS_DIR_PATH
+                );
+            }
             $responseMove = !is_wp_error($resultMove) && $result;
 
             return $responseMove;

visualcomposer/Modules/Migrations/UpdateGlobalElementsMigration.php

@@ -80,8 +80,9 @@ protected function run()
 
                 if (!empty($previousCssFile) && empty($previousCssHash)) {
                     $assetsPath = $assetsHelper->getFilePath($previousCssFile);
-                    if (!empty($assetsPath)) {
-                        $fileHelper->getFileSystem()->delete($assetsPath);
+                    $fileSystem = $fileHelper->getFileSystem();
+                    if ($fileSystem && !empty($assetsPath)) {
+                        $fileSystem->delete($assetsPath);
                     }
                 }
             }