Skip to content

Commit 26df891

Browse files
konutiskonutis
authored
Add lint for TS VC-2813 (#2020)
* Add lint for TS VC-2813 * Fix eslint errors VC-2813 * Add correct indentation VC-2813 * Remove standard, add JS to eslint VC-2813 * Fix eslint errors and warnings * Fix eslint errors and warnings VC-2813 * Update eslint codestyle VC-2813 * FIx eslint VC-2813 * Fix eslint VC-2813 * Add more rules VC-2813 * Fix eslint VC-2813 * Add dependency inside VC-2813
1 parent e66603d commit 26df891

File tree

133 files changed

+1154
-1334
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

133 files changed

+1154
-1334
lines changed

‎.circleci/config.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ jobs:
1414
- v1-node-codestyle-{{ arch }}-
1515
- run: npm install -g n
1616
- run: n 14
17-
- run: yarn install --frozen-lockfile && yarn standard
17+
- run: yarn install --frozen-lockfile
18+
- run: yarn lint
1819
- save_cache:
1920
key: v1-node-codestyle-{{ arch }}-{{ .Branch }}-{{ checksum "package.json" }}
2021
paths:

‎.editorconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ charset = utf-8
66
trim_trailing_whitespace = true
77
end_of_line = lf
88

9-
[*.{js,json}]
9+
[*.{js,json,ts,tsx}]
1010
indent_style = space
1111
indent_size = 2

‎.eslintrc.json

+228
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,228 @@
1+
{
2+
"settings": {
3+
"react": {
4+
"pragma": "React",
5+
"version": "detect"
6+
}
7+
},
8+
"env": {
9+
"browser": true,
10+
"commonjs": true,
11+
"node": true
12+
},
13+
"parser": "@typescript-eslint/parser",
14+
"plugins": [
15+
"@typescript-eslint"
16+
],
17+
"extends": [
18+
"eslint:recommended",
19+
"plugin:@typescript-eslint/eslint-recommended",
20+
"plugin:@typescript-eslint/recommended",
21+
"plugin:react-hooks/recommended",
22+
"plugin:react/recommended",
23+
"plugin:import/recommended"
24+
],
25+
"rules": {
26+
"@typescript-eslint/ban-ts-comment": "off",
27+
"@typescript-eslint/no-var-requires": "off",
28+
"import/no-unresolved": "off",
29+
"import/no-webpack-loader-syntax": "off",
30+
"react/prop-types": 0,
31+
"semi": ["error", "never"],
32+
"quotes": ["error", "single", { "avoidEscape": true, "allowTemplateLiterals": false }],
33+
"accessor-pairs": "error",
34+
"array-bracket-spacing": ["error", "never"],
35+
"arrow-spacing": ["error", { "before": true, "after": true }],
36+
"block-spacing": ["error", "always"],
37+
"brace-style": ["error", "1tbs", { "allowSingleLine": true }],
38+
"camelcase": ["error", { "properties": "never" }],
39+
"comma-dangle": ["error", {
40+
"arrays": "never",
41+
"objects": "never",
42+
"imports": "never",
43+
"exports": "never",
44+
"functions": "never"
45+
}],
46+
"comma-spacing": ["error", { "before": false, "after": true }],
47+
"comma-style": ["error", "last"],
48+
"computed-property-spacing": ["error", "never"],
49+
"constructor-super": "error",
50+
"curly": ["error", "multi-line"],
51+
"dot-location": ["error", "property"],
52+
"dot-notation": ["error", { "allowKeywords": true }],
53+
"eol-last": "error",
54+
"eqeqeq": ["error", "always", { "null": "ignore" }],
55+
"func-call-spacing": ["error", "never"],
56+
"generator-star-spacing": ["error", { "before": true, "after": true }],
57+
"handle-callback-err": ["error", "^(err|error)$" ],
58+
"indent": ["error", 2, {
59+
"SwitchCase": 1,
60+
"VariableDeclarator": 1,
61+
"outerIIFEBody": 1,
62+
"MemberExpression": 1,
63+
"FunctionDeclaration": { "parameters": 1, "body": 1 },
64+
"FunctionExpression": { "parameters": 1, "body": 1 },
65+
"CallExpression": { "arguments": 1 },
66+
"ArrayExpression": 1,
67+
"ObjectExpression": 1,
68+
"ImportDeclaration": 1,
69+
"flatTernaryExpressions": false,
70+
"ignoreComments": false,
71+
"ignoredNodes": ["TemplateLiteral *"]
72+
}],
73+
"key-spacing": ["error", { "beforeColon": false, "afterColon": true }],
74+
"keyword-spacing": ["error", { "before": true, "after": true }],
75+
"lines-between-class-members": ["error", "always", { "exceptAfterSingleLine": true }],
76+
"new-cap": ["error", { "newIsCap": true, "capIsNew": false, "properties": true }],
77+
"new-parens": "error",
78+
"no-array-constructor": "error",
79+
"no-async-promise-executor": "error",
80+
"no-caller": "error",
81+
"no-case-declarations": "error",
82+
"no-class-assign": "error",
83+
"no-compare-neg-zero": "error",
84+
"no-cond-assign": "error",
85+
"no-const-assign": "error",
86+
"no-constant-condition": ["error", { "checkLoops": false }],
87+
"no-control-regex": "error",
88+
"no-debugger": "error",
89+
"no-delete-var": "error",
90+
"no-dupe-args": "error",
91+
"no-dupe-class-members": "error",
92+
"no-dupe-keys": "error",
93+
"no-duplicate-case": "error",
94+
"no-empty-character-class": "error",
95+
"no-empty-pattern": "error",
96+
"no-eval": "error",
97+
"no-ex-assign": "error",
98+
"no-extend-native": "error",
99+
"no-extra-bind": "error",
100+
"no-extra-boolean-cast": "error",
101+
"no-extra-parens": ["error", "functions"],
102+
"no-fallthrough": "error",
103+
"no-floating-decimal": "error",
104+
"no-func-assign": "error",
105+
"no-global-assign": "error",
106+
"no-implied-eval": "error",
107+
"no-inner-declarations": ["error", "functions"],
108+
"no-invalid-regexp": "error",
109+
"no-irregular-whitespace": "error",
110+
"no-iterator": "error",
111+
"no-labels": ["error", { "allowLoop": false, "allowSwitch": false }],
112+
"no-lone-blocks": "error",
113+
"no-misleading-character-class": "error",
114+
"no-prototype-builtins": "error",
115+
"no-useless-catch": "error",
116+
"no-mixed-operators": ["error", {
117+
"groups": [
118+
["==", "!=", "===", "!==", ">", ">=", "<", "<="],
119+
["&&", "||"],
120+
["in", "instanceof"]
121+
],
122+
"allowSamePrecedence": true
123+
}],
124+
"no-mixed-spaces-and-tabs": "error",
125+
"no-multi-spaces": "error",
126+
"no-multi-str": "error",
127+
"no-multiple-empty-lines": ["error", { "max": 1, "maxEOF": 0 }],
128+
"no-negated-in-lhs": "error",
129+
"no-new": "error",
130+
"no-new-func": "error",
131+
"no-new-object": "error",
132+
"no-new-require": "error",
133+
"no-new-symbol": "error",
134+
"no-new-wrappers": "error",
135+
"no-obj-calls": "error",
136+
"no-octal": "error",
137+
"no-octal-escape": "error",
138+
"no-path-concat": "error",
139+
"no-proto": "error",
140+
"no-redeclare": ["error", { "builtinGlobals": false }],
141+
"no-regex-spaces": "error",
142+
"no-return-assign": ["error", "except-parens"],
143+
"no-self-assign": ["error", { "props": true }],
144+
"no-self-compare": "error",
145+
"no-sequences": "error",
146+
"no-shadow-restricted-names": "error",
147+
"no-sparse-arrays": "error",
148+
"no-tabs": "error",
149+
"no-template-curly-in-string": "error",
150+
"no-this-before-super": "error",
151+
"no-throw-literal": "error",
152+
"no-trailing-spaces": "error",
153+
"no-undef": "error",
154+
"no-undef-init": "error",
155+
"no-unexpected-multiline": "error",
156+
"no-unmodified-loop-condition": "error",
157+
"no-unneeded-ternary": ["error", { "defaultAssignment": false }],
158+
"no-unreachable": "error",
159+
"no-unsafe-finally": "error",
160+
"no-unsafe-negation": "error",
161+
"no-unused-expressions": ["error", { "allowShortCircuit": true, "allowTernary": true, "allowTaggedTemplates": true }],
162+
"no-unused-vars": ["error", { "vars": "all", "args": "none", "ignoreRestSiblings": true }],
163+
"no-use-before-define": ["error", { "functions": false, "classes": false, "variables": false }],
164+
"no-useless-call": "error",
165+
"no-useless-computed-key": "error",
166+
"no-useless-constructor": "error",
167+
"no-useless-escape": "error",
168+
"no-useless-rename": "error",
169+
"no-useless-return": "error",
170+
"no-void": "error",
171+
"no-whitespace-before-property": "error",
172+
"no-with": "error",
173+
"object-curly-newline": ["error", { "multiline": true, "consistent": true }],
174+
"object-curly-spacing": ["error", "always"],
175+
"object-property-newline": ["error", { "allowMultiplePropertiesPerLine": true }],
176+
"one-var": ["error", { "initialized": "never" }],
177+
"operator-linebreak": ["error", "after", { "overrides": { "?": "before", ":": "before", "|>": "before" } }],
178+
"padded-blocks": ["error", { "blocks": "never", "switches": "never", "classes": "never" }],
179+
"prefer-const": ["error", {"destructuring": "all"}],
180+
"prefer-promise-reject-errors": "error",
181+
"quote-props": ["error", "as-needed"],
182+
"rest-spread-spacing": ["error", "never"],
183+
"semi-spacing": ["error", { "before": false, "after": true }],
184+
"space-before-blocks": ["error", "always"],
185+
"space-before-function-paren": ["error", "always"],
186+
"space-in-parens": ["error", "never"],
187+
"space-infix-ops": "error",
188+
"space-unary-ops": ["error", { "words": true, "nonwords": false }],
189+
"spaced-comment": ["error", "always", {
190+
"line": { "markers": ["*package", "!", "/", ",", "="] },
191+
"block": { "balanced": true, "markers": ["*package", "!", ",", ":", "::", "flow-include"], "exceptions": ["*"] }
192+
}],
193+
"symbol-description": "error",
194+
"template-curly-spacing": ["error", "never"],
195+
"template-tag-spacing": ["error", "never"],
196+
"unicode-bom": ["error", "never"],
197+
"use-isnan": "error",
198+
"valid-typeof": ["error", { "requireStringLiterals": true }],
199+
"wrap-iife": ["error", "any", { "functionPrototypeMethods": true }],
200+
"yield-star-spacing": ["error", "both"],
201+
"yoda": ["error", "never"],
202+
203+
"import/export": "error",
204+
"import/first": "error",
205+
"import/no-absolute-path": ["error", { "esmodule": true, "commonjs": true, "amd": false }],
206+
"import/no-duplicates": "error",
207+
"import/no-named-default": "error"
208+
},
209+
"ignorePatterns": [
210+
"**/*.babel.js",
211+
"**/*.bundle.js",
212+
"**/*.spec.js",
213+
"**/*.min.js",
214+
"public/editor/modules/insights/axe.d.ts",
215+
"**/commands.js",
216+
"elements/*/public/*",
217+
"devAddons/*",
218+
"_infrastructure/*",
219+
"devElements/*",
220+
"public/config/*",
221+
"public/dist/*",
222+
"tests/*",
223+
"tools/*",
224+
"public/config/",
225+
"public/sources/assetsLibrary/*"
226+
],
227+
"root": true
228+
}

‎elements/facebookLike/facebookLike/component.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export default class FacebookLike extends vcvAPI.elementComponent {
88

99
constructor (props) {
1010
super(props)
11+
this.facebookLikeInner = React.createRef()
1112
this.state = {
1213
status: ''
1314
}
@@ -32,7 +33,7 @@ export default class FacebookLike extends vcvAPI.elementComponent {
3233

3334
insertHtml (atts) {
3435
const html = this.createHtml(atts)
35-
const wrapper = this.refs.facebookLikeInner
36+
const wrapper = this.facebookLikeInner.current
3637
this.updateInlineHtml(wrapper, html)
3738
this.reloadScript()
3839
this.setPlaceholder()
@@ -45,7 +46,7 @@ export default class FacebookLike extends vcvAPI.elementComponent {
4546
}
4647
const helper = document.createElement('div')
4748
helper.className = 'vcvhelper vce-facebook-like-placeholder'
48-
this.refs.facebookLikeInner.appendChild(helper)
49+
this.facebookLikeInner.current.appendChild(helper)
4950
const helperSelector = this.getDomNode().querySelector('.vce-facebook-like-placeholder')
5051

5152
likeBtn.style.position = 'absolute'
@@ -166,7 +167,7 @@ export default class FacebookLike extends vcvAPI.elementComponent {
166167

167168
return (
168169
<div {...customProps} className={classes} {...editor}>
169-
<div className={innerClasses} ref='facebookLikeInner' id={'el-' + id} {...doAll}>Facebook Like</div>
170+
<div className={innerClasses} ref={this.facebookLikeInner} id={'el-' + id} {...doAll}>Facebook Like</div>
170171
</div>
171172
)
172173
}

‎elements/flickrImage/flickrImage/component.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export default class FlickrImage extends vcvAPI.elementComponent {
1313

1414
constructor (props) {
1515
super(props)
16+
this.flickerInner = React.createRef()
1617
const _ = require('lodash')
1718
this.handleResize = _.debounce(this.handleResize.bind(this), 200)
1819
}
@@ -85,9 +86,9 @@ export default class FlickrImage extends vcvAPI.elementComponent {
8586
}
8687

8788
appendFlickr (tagString = '') {
88-
this.refs.flickerInner.innerHTML = ''
89+
this.flickerInner.current.innerHTML = ''
8990
window.setTimeout(() => {
90-
this.updateInlineHtml(this.refs.flickerInner, tagString)
91+
this.updateInlineHtml(this.flickerInner.current, tagString)
9192
}, 0)
9293
}
9394

@@ -152,7 +153,7 @@ export default class FlickrImage extends vcvAPI.elementComponent {
152153
return (
153154
<div {...customProps} className={classes} {...editor}>
154155
<div id={'el-' + id} className={wrapperClasses} {...doAll}>
155-
<div className={innerClasses} {...innerCustomProps} ref='flickerInner' />
156+
<div className={innerClasses} {...innerCustomProps} ref={this.flickerInner} />
156157
{content}
157158
</div>
158159
</div>

‎elements/googleMaps/googleMaps/component.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ export default class GoogleMaps extends vcvAPI.elementComponent {
99
height: '450'
1010
}
1111

12+
constructor (props) {
13+
super(props)
14+
this.mapInner = React.createRef()
15+
}
16+
1217
componentDidMount () {
1318
if (this.props.atts.embed) {
1419
this.setCustomSize(this.props.atts, this.getDefaultSize(this.props.atts.embed))
@@ -89,7 +94,7 @@ export default class GoogleMaps extends vcvAPI.elementComponent {
8994
}
9095

9196
appendMap (tagString = '') {
92-
const component = this.refs.mapInner
97+
const component = this.mapInner.current
9398
component.innerHTML = tagString
9499
}
95100

@@ -141,7 +146,7 @@ export default class GoogleMaps extends vcvAPI.elementComponent {
141146
return (
142147
<div {...customProps} className={classes} {...editor}>
143148
<div className={wrapperClasses} {...wrapperProps} id={'el-' + id} {...doAll}>
144-
<div className={innerClasses} {...innerProps} ref='mapInner' />
149+
<div className={innerClasses} {...innerProps} ref={this.mapInner} />
145150
</div>
146151
</div>
147152
)

‎elements/imageGallery/imageGallery/component.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default class ImageGallery extends vcvAPI.elementComponent {
2828
prepareImage (image) {
2929
if (image.length && typeof image[0] === 'object') {
3030
const newImages = []
31-
image.forEach((item, index) => {
31+
image.forEach((item) => {
3232
const newItem = item
3333
newItem.full = newItem.id ? newItem.full : this.getImageUrl(newItem.full)
3434
newItem.id = newItem.id ? newItem.id : Math.random()

‎elements/pinterestPinit/pinterestPinit/component.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ import vcCake from 'vc-cake'
44
const vcvAPI = vcCake.getService('api')
55

66
export default class PinterestPinit extends vcvAPI.elementComponent {
7+
constructor (props) {
8+
super(props)
9+
this.pinterestInner = React.createRef()
10+
}
11+
712
componentDidMount () {
813
this.insertHtml(this.props.atts)
914
}
@@ -18,7 +23,7 @@ export default class PinterestPinit extends vcvAPI.elementComponent {
1823
const button = this.createHtml(props)
1924
const script = '<script type="text/javascript" async defer src="https://assets.pinterest.com/js/pinit.js"></script>'
2025
const html = button + script
21-
const wrapper = this.refs.pinterestInner
26+
const wrapper = this.pinterestInner.current
2227
this.updateInlineHtml(wrapper, html)
2328

2429
const iframe = document.querySelector('#vcv-editor-iframe').contentWindow
@@ -75,7 +80,7 @@ export default class PinterestPinit extends vcvAPI.elementComponent {
7580

7681
return (
7782
<div {...customProps} className={classes} {...editor}>
78-
<div className={innerClasses} ref='pinterestInner' id={'el-' + id} {...doAll}>Google Plus Button</div>
83+
<div className={innerClasses} ref={this.pinterestInner} id={'el-' + id} {...doAll}>Google Plus Button</div>
7984
</div>
8085
)
8186
}

0 commit comments

Comments
 (0)