Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: number of simulated steps #78

Open
lilijap opened this issue Jan 29, 2025 · 0 comments
Open

BUG: number of simulated steps #78

lilijap opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lilijap
Copy link

lilijap commented Jan 29, 2025

Describe the bug
By providing explicit number of steps for the simulation, e.g., "simulate for 2016 hours with 2016 intervals" in some cases Simulator agent uses just 1 step or 10 by default. The choice of the step-size is not stable. If the simulator selected too few steps, the time-courses are not reproduced correctly.

Default 10 steps:

Image

100 steps ("simulate biomodel 537 for 2016 hours with 100 intervals"):

Image

1 Step ("simulate biomodel 537 for 2016 hours with 2016 steps")

Image

Expected behavior
I would recommend run_simulations tool to use at least 100 steps by default, never simulate by using 1 step.

@lilijap lilijap added the bug Something isn't working label Jan 29, 2025
@lilijap lilijap added this to the Talk2BioModels release v2.0.0 milestone Jan 29, 2025
@lilijap lilijap changed the title BUG: number of steps in the simulation BUG: number of simulated steps Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants