orderBy in modifiers doesn't work

[michellechsy]

Hi Team,

when i define the modifiers in my Model and then query it as a relation in another Model, the orderBy is not generated in the final query (with knex.js) while where condition works. I also check the samples provided in your code, i'm writing the same but with 'desc' order! Can you please help ?

// in my relation Model A:
  static get modifiers() {
    return {
      lastSession (builder) {
        builder.where('status', '<>', 'CURRENT')
      },
      orderByTime (builder) {
        builder.orderBy('createdAt', 'desc')
      }
    }
  }

in my Model B, i define a HasMany relation with Model A.

static get relationMappings() {
    return {
      sessions: {
        relation: Model.HasManyRelation,
        modelClass: ModelA,
        join: {
          from: 'ModelB.id',
          to: 'ModelA.userId'
        }
      }
}

then i query Model B with model A:

ModelB.query().orderBy('id', 'asc').withGraphFetched('sessions(lastSession, orderByTime)')

the result of sessions will always return by id (asc), instead of 'createdAt desc'.

[kapouer]

Can you check what happens when you declare the modifiers like this:

ModelB.query().orderBy('id', 'asc').withGraphFetched('sessions(lastSession, orderByTime)').modifiers({
      lastSession (builder) {
        builder.where('status', '<>', 'CURRENT')
      },
      orderByTime (builder) {
        builder.orderBy('createdAt', 'desc')
      }
})

[epam-vendor]

Hi @kapouer ,
I've changed my code logic to avoid that modifier, but now i got another issue:
ModelA.query().leftJoinRelated('modelB').select(modelA.*, modelB.createdAt as bCreatedAt).orderBy('modelB.createdAt', 'desc')
when i use this kindof query with pagination (objection-cursor), in my second page call, it passed the modelA.createdAt value to my pagination instead of modelB.createdAt based on the knex debug query ( where ([modelB].[created_at] < ?)),
how should i fix it