[ObjC] Tens of thousands of lines of log spew related to undo when opening Objective-C binary

[bdash]

Version and Platform (required):

• Binary Ninja Version: 5.1.7529-dev (0853e7bf)
• OS: macOS 15.5
• CPU Architecture: arm64

Bug Description:
When opening /usr/libexec/syspolicyd (or any other binary containing Objective-C code), there's a massive volume of log spew of the form:

[Undo warn] Refusing to add undo action "Defined variable type in function -[StagedSample setType:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Set function type for -[StagedSample setType:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Defined variable self in function -[StagedSample initWithUrl:uuid:type:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Defined variable sel in function -[StagedSample initWithUrl:uuid:type:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Defined variable url in function -[StagedSample initWithUrl:uuid:type:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Defined variable uuid in function -[StagedSample initWithUrl:uuid:type:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Defined variable type in function -[StagedSample initWithUrl:uuid:type:]" for unfinalized view of type "Mach-O"
[Undo warn] Refusing to add undo action "Set function type for -[StagedSample initWithUrl:uuid:type:]" for unfinalized view of type "Mach-O"

For syspolicyd there's around 10,000 of these warnings generated. For tccd there 17,000.

Surely it'd be sufficient to log this once per view?

Steps To Reproduce:

1. Load literally any Mach-O binary containing Objective-C code.

[fuzyll]

@bdash Ah, sorry, this is related to a commit we landed earlier today (in the exact version you are mentioning above). This should indicate a problem on our end and the correct thing would be to fix the underlying problem. But, I don't think we knew Objective-C stuff would trigger it. The bug that was being addressed is something we had only seen in user plugins that added undo actions during view initialization (which was causing crashes).

@negasora are you able to confirm whether this is an issue with the workflow or if this is an issue with the crash fix you added that's maybe too broad? Not sure which place needs changed (the undo actions or the workflow), but obviously this shouldn't be happening with a standard thing we ship. 😬

[emesare]

Should be fixed now with 85d51ee. On dev with >=7532.

[bdash]

This is back again and it looks like it was a result of #6814. 4,700 lines of log spew when opening syspolicyd.

1. Can we please update whatever is logging these messages to log once per type of message, rather than for every call?
2. I don't see any alternatives to AddUserDataReference to avoid implicitly creating an undo operation.