Multiple Rust Headless Sessions leads to segfault

[ekilmer]

Reproduction repo https://github.com/trailofbits/binja-rust-load-issue

Version and Platform (required):

• v5.0.7255-dev
• OS: macOS (but probably fails on other systems as well)
• OS Version: 15.4.1
• CPU Architecture: M2

Bug Description:

Loading binaries into multiple headless sessions leads to segfault (see repo for backtrace and code).

Steps To Reproduce:

• Clone repo with submodules and follow README

Expected Behavior:
Not a segfault.

Screenshots/Video Recording:
See repo README for output and backtrace.

Binary:

Clone the repo with submodules git clone --recurse-submodules

Additional Information:

The preferred way is probably to use a single headless session, but I don't think a segfault is desired in safe Rust code, i.e. if I can compile my own code with no unsafe Rust, I shouldn't have a crash like this.

[emesare]

I 100% agree this should not crash, we have added rust unit tests that explicitly depend on this behavior. Within the core initialization there needs to be a few more mutexes. The rust session guard also is likely not helping.

I am going to tag this as impact high to note the priority that this be resolved, unfortunately this is not blocking for the release as there is a workaround for this (only initialize the core once and forgo using the session guard).