"Close and Reopen" results in Multiple Open Windows on Same BNDB, Preventing Saving

[w1282]

Version and Platform (required):

• Binary Ninja Version: 3.3.4048-dev
• OS: Windows
• OS Version: 10
• CPU Architecture: x64

Bug Description:
When "Close and Reopen" or "Update" cause BN to reopen active windows spawned from the same view (e.g. 'Split View' -> Drag into new Window), each window is reopened in a separate, unrelated process. This causes file contention when trying to save, and unless the user is aware of the underlying issue, it causes confusion around things like 'Sync Groups' not being synchronized even though both windows show themselves being sync'd.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Open a file for analysis
2. Cause a view to split
3. Drag one view into a new Window
4. Execute Close and Reopen
5. Once respawned, make a change in one of the windows
6. Attempt to save and observe the file contention

Expected Behavior:
Multiple views spawned from the same BN instance would reopen under the same process, maintaining cross-view synchronizations, and changes from one would reflect in the other. Alternatively, just reopen one instance and lose extraneous views.

Screenshots:
If applicable, please add screenshots here to help explain your problem.

Additional Information:
Not a particular nuisance, since the resolution is to just close one process without saving, but if the user didn't catch on soon enough and worked in both views they might end up losing some volume of work.

https://binaryninja.slack.com/archives/C0CV88A83/p1675892840609979

[galenbwill]

To clarify, it would be multiple windows, but still within a single process. However, this is enough to cause the save conflict, since the first open view on the BNDB will lock it and prevent other open views from saving. This would also be true if there were multiple tabs open, I believe.

The only effective mitigation I can think of is not to re-open multiple views of the same BNDB on restart, but this would violate the UX contract of "Restart and Reopen".