Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To wrap or not? #253

Open
ue71603 opened this issue Oct 6, 2022 · 1 comment
Open

To wrap or not? #253

ue71603 opened this issue Oct 6, 2022 · 1 comment
Milestone

Comments

@ue71603
Copy link
Contributor

ue71603 commented Oct 6, 2022

In OJP we have some wrappers that are not really doing anything but wrap a Siri element e.g. element: name="ServiceFacilityGroup" (in «OJP_FacilitySupport.xsd») :

<xs:group name="ServiceFacilityGroup">
	<xs:annotation>
		<xs:documentation>Wrapper for SIRI service facilities.</xs:documentation>
	</xs:annotation>
	<xs:sequence>
		<xs:group ref="siri:ServiceFacilityGroup"/>
	</xs:sequence>
</xs:group>

/ServiceFacilityGroup/groupRef/ServiceFacilityGroup
/AllFacilitiesGroup/groupRef/AllFacilitiesGroup
/StopFacilityGroup/groupRef/StopFacilityGroup
/DeliveryRequestGroup/groupRef/DeliveryRequestGroup
/StatusRequestGroup/groupRef/StatusRequestGroup
/ServiceResponseGroup/groupRef/ServiceResponseGroup

@skinkie @sgrossberndt @Aurige : Should we keep the wrappers or remove them?

@ue71603 ue71603 added the question Further information is requested label Oct 6, 2022
@ue71603 ue71603 added this to the v2.0 milestone Oct 6, 2022
@ue71603 ue71603 self-assigned this Oct 6, 2022
@ue71603 ue71603 modified the milestones: v2.0, later Oct 18, 2022
@ue71603 ue71603 removed question Further information is requested to be disussed labels Oct 18, 2022
@ue71603 ue71603 removed their assignment Oct 18, 2022
@ue71603 ue71603 modified the milestones: later, v2.1 Aug 17, 2023
@Aurige
Copy link
Contributor

Aurige commented Oct 12, 2023

It does not harm and may help some future extensions ... so I would just let them as they are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants