chore: fix/ignore shellcheck warnings.

comment(pyenv, gf): add todos.

chore(rfsn): clean up code.

Author: UserIsntAvailable

chead

@@ -2,7 +2,7 @@
 
 set -euo pipefail
 
-# Prints a Centered HEADer. i.e: the header bellow
+# Prints a Centered HEADer. i.e: the function header bellow.
 
 # Dependencies:
 # rev
@@ -12,9 +12,9 @@ set -euo pipefail
 Usage()
 {
     # TODO: Maybe rethink names of flags?
-    while read; do
+    while read -r; do
         printf '%s\n' "$REPLY"
-    done <<- EOF
+    done <<-EOF
         Usage: chead [OPTS] TEXT
 
           -h, --help              - Display this help information.
@@ -31,6 +31,7 @@ Usage()
 Err()
 {
     printf "Err: %s\n" "$2" 1>&2
+    # shellcheck disable=2086
     (($1 > 0)) && exit $1
 }
 
@@ -107,18 +108,18 @@ if [[ $MirrorStart == true ]]; then
 fi
 
 # TODO: Add better error message ( include the actual inputs ).
-((${#HeaderText} + $StartCharCount + ${#PaddingChar} * 2 > $MaxLength)) &&
-    Err 1 "The combination of all inputs is higher than '$MaxLength'"
+((${#HeaderText} + StartCharCount + ${#PaddingChar} * 2 > MaxLength)) \
+    && Err 1 "The combination of all inputs is higher than '$MaxLength'"
 
 # ----------------------------------- Main ----------------------------------- #
 
-PaddingLength=$(($MaxLength - ${#HeaderText} - ${#StartChar}))
+PaddingLength=$((MaxLength - ${#HeaderText} - ${#StartChar}))
 
 if [[ $MirrorStart == true ]]; then
-    PaddingLength=$(($PaddingLength - ${#StartChar}))
+    PaddingLength=$((PaddingLength - ${#StartChar}))
 fi
 
-PaddingLength=$(($PaddingLength / 2 / ${#PaddingChar} - 1))
+PaddingLength=$((PaddingLength / 2 / ${#PaddingChar} - 1))
 
 for ((I = 0; I <= PaddingLength; I++)); do
     Padding+="$PaddingChar"
@@ -132,7 +133,7 @@ printf -v Result "%s%s%s%s" "$StartChar" "$Padding" "$HeaderText" "$Padding"
 # instead, and keep both behaviours.
 
 if [[ $MirrorStart == true ]]; then
-    printf "%s%s\n" "$Result" "$(rev <<< "$StartChar")"
+    printf "%s%s\n" "$Result" "$(rev <<<"$StartChar")"
 else
     echo "$Result"
 fi

fzf/gd

@@ -2,8 +2,7 @@
 
 # Fuzzy find a directory, then cd to it.
 
-# Notes:
-# Keep in mind that if you want to see the effect of cd you need to
+# NOTE: Keep in mind that if you want to see the effect of cd you need to
 # source the script.
 
 # Dependecies:
@@ -17,7 +16,7 @@ Usage()
 {
     while read -r; do
         printf "%s\n" "$REPLY"
-    done <<- EOF
+    done <<-EOF
         Usage: gd [OPTS] [BASEDIR]
 
           -h, --help     - Display this help information.
@@ -40,12 +39,14 @@ Err()
     printf "Err: %s\n" "$2" 1>&2
     if (($1 > 0)); then
         UnsetVars
+        # shellcheck disable=2086
         return $1
     fi
 }
 
 # ----------------------------- Input Processing ----------------------------- #
 
+# shellcheck disable=2046
 (($# > 3)) && return $(Err 1 "Too many arguments.")
 
 Command="cd"
@@ -58,14 +59,18 @@ while [[ -n $1 ]]; do
             ;;
         --absolute | -a) Command="realpath" ;;
         --relative | -r) Command="echo" ;;
-        -*) return $(Err 1 "Incorrect option(s) specified.") ;;
+        -*)
+            # shellcheck disable=2046
+            return $(Err 1 "Incorrect option(s) specified.")
+            ;;
         *) break ;;
     esac
     shift
 done
 
 BaseDir="${1:-$HOME}"
 
+# shellcheck disable=2046
 [[ -d $BaseDir ]] || return $(Err 1 "Directory '$BaseDir' doesn't exists.")
 
 # ----------------------------------- Main ----------------------------------- #

fzf/gf

@@ -2,9 +2,8 @@
 
 # Fuzzy find a file, move to that file directory, and then opens it on $EDITOR.
 
-# Notes:
-# Keep in mind that if you want to cd automatically to the file you need to
-# source the script. I will just recommend to create an alias/keybind.
+# NOTE: Keep in mind that if you want to cd automatically to the file you need
+# to source the script. I will just recommend to create an alias/keybind.
 #
 # I'm using `return`s, instead of `exit`s because this script needs to handle
 # the case where it is `source`d instead of being run normally.
@@ -14,14 +13,16 @@
 # fzf
 
 # TODO: Save value of $_GF_LAST_FILE_VISITED on a temp file.
+# TODO: Include '-a', and '-r' from GD
+# TODO: Merge `gd`, and `gf`.
 
 # -------------------------------- Functions -------------------------------- #
 
 Usage()
 {
     while read -r; do
         printf "%s\n" "$REPLY"
-    done <<- EOF
+    done <<-EOF
         Usage: gf [BASEDIR]
 
           -h, --help                   - Display this help information.
@@ -42,18 +43,21 @@ Err()
     printf "Err: %s\n" "$2" 1>&2
     if (($1 > 0)); then
         UnsetVars
+        # shellcheck disable=2086
         return $1
     fi
 }
 
 FzfToFile()
 {
+    # shellcheck disable=2046
     cd "${1%/*}" || return $(Err 1 "Wasn't possible to cd into '${1%/*}'.")
     $EDITOR "${1##*/}"
 }
 
 # ----------------------------- Input Processing ----------------------------- #
 
+# shellcheck disable=2046
 (($# > 1)) && return $(Err 1 "Too many arguments.")
 
 case $1 in
@@ -65,17 +69,20 @@ case $1 in
         if [[ -n "$_GF_LAST_FILE_VISITED" ]]; then
             FzfToFile "$_GF_LAST_FILE_VISITED" && return 0 || return 1
         else
+            # shellcheck disable=2046
             return $(Err 1 "No previous file visited.")
         fi
         ;;
 esac
 
 BaseDir="${1:-$HOME}"
 
+# shellcheck disable=2046
 [[ -d $BaseDir ]] || return $(Err 1 "Directory '$BaseDir' doesn't exists.")
 
 File=$(fd -tf -tl -H --exclude .git . "$BaseDir" | fzf -i +m --black)
 
+# shellcheck disable=2046
 [[ -r $File ]] || return $(Err 1 "File '$File' is not readable.")
 
 # ----------------------------------- Main ----------------------------------- #

python/pyenv

@@ -18,6 +18,8 @@ set -euo pipefail
 # test that edge case now.
 #
 # TODO: Verbose flag.
+#
+# TODO: --stop: stop searching searching venv after reaching `STOP` dir.
 
 # -------------------------------- Functions -------------------------------- #
 

rfsn

@@ -87,11 +87,11 @@ for Argument in "$@"; do
     BaseName=${Argument##*/}
     BaseName=${BaseName,,}
     BaseName=${BaseName/" "/$Sep}
-    BaseName=${BaseName/":"/"-"}
+    BaseName=${BaseName/":"/$Sep}
 
-    if [[ $ForceUnderscore == true ]]; then
+    if [[ $ForceHyphen == true ]]; then
         BaseName=${BaseName/"-"/$Sep}
-    elif [[ $ForceHyphen == true ]]; then
+    elif [[ $ForceUnderscore == true ]]; then
         BaseName=${BaseName/"_"/$Sep}
     fi
 

up

@@ -2,11 +2,12 @@
 
 # Cd `up` an x amount of folders
 
-# notes: keep in mind that if you want to see the effect of cd you need to source the file.
+# NOTE: keep in mind that if you want to see the effect of cd you need to source the file.
 
 Amount=${1:-1}
 
 if ((Amount <= 0)); then
+    # shellcheck disable=2086
     printf "You can't cd up %s times\n" $Amount 1>&2
     return 1
 fi
@@ -15,7 +16,7 @@ for ((I = 1; I <= Amount; I++)); do
     Level+=../
 done
 
-cd $Level
+cd $Level || return 1
 
 unset Amount
 unset Level