Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default retention time is being overwritten #54

Open
clamb-respondent opened this issue Jan 31, 2023 · 3 comments
Open

Default retention time is being overwritten #54

clamb-respondent opened this issue Jan 31, 2023 · 3 comments

Comments

@clamb-respondent
Copy link

Is your feature request related to a problem? Please describe.
Variables stored on friday will expire by monday since the retention period is set to 1.
https://github.com/UnlyEd/github-action-store-variable/blob/main/src/manageArtifacts.ts#L49

Describe the solution you'd like
If the value was set to 0 then it looks like the default retention setting would be taken.

@Vadorequest
Copy link
Member

Hi, I wasn't aware of that configuration.

I'm not sure what would be the "default" value. See https://github.com/actions/toolkit/blob/c861dd8859fe5294289fcada363ce9bc71e9d260/packages/artifact/src/internal/upload-options.ts#L1

What value would you need for your use case? I believe this could become a new option, with 1 by default, to keep the current behavior by default.

@clamb-respondent
Copy link
Author

Thinking of storing a slack_thread_id so that when a PR is updated the correct slack message is updated too. That said; it's looking like i could just use actions/cache@v3 to store them and pull it from that.

@Vadorequest
Copy link
Member

I wonder if this project is still useful to anyone, I believe the core "setstate" function makes it useless now.

#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants