Skip to content

Commit 920ab63

Browse files
committed
Add TODO
1 parent 94d41ec commit 920ab63

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/vercel.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ const createAliases = async (deploymentUrl: string, customDeploymentFile: string
9494

9595
// Sanitizing
9696
aliasesToCreate = aliasesToCreate.map((alias: string) => {
97-
const subdomain: string = alias.split('.')?.[0];
97+
const subdomain: string = alias.split('.')?.[0]; // TODO strip "-" at the end to avoid breaking urls when last chars is a "-"
9898

9999
if (subdomain?.length > 63) {
100100
core.warning(`Alias is too long (< 63 chars) and will be stripped: ${subdomain}`);

0 commit comments

Comments
 (0)