Hide help text in static source metadata form (#37 #517)

Author: jgonggrijp

frontend/src/source-metadata/date-field-template.hbs

@@ -1,5 +1,5 @@
 <div class="field date">
-    <label class="label">{{label}}</label>
+    <label class="label">{{label}}{{^required}}{{^readonly}} {{#i18n 'label.suffix-optional'}}(optional){{/i18n}}{{/readonly}}{{/required}}</label>
     <div class="control">
         <input name={{name}} class="input with-help" type="text" {{#unless readonly}}placeholder="1952-09-01 (YYYY-MM-DD)"{{/unless}} {{#readonly}}readonly{{/readonly}} {{#required}}required{{/required}}>
         <p class="help">{{{additionalHelpText}}}

frontend/src/source-metadata/source-metadata-template.hbs

@@ -11,19 +11,19 @@
     </div>
 </div>
 <div class="field">
-    <label class="label">{{#i18n 'label.editor-opt'}}Editor (optional){{/i18n}}</label>
+    <label class="label">{{#i18n 'label.editor'}}Editor{{/i18n}}{{^readonly}} {{#i18n 'label.suffix-optional'}}(optional){{/i18n}}{{/readonly}}</label>
     <div class="control">
         <input name="editor" class="input" type="text" {{#unless readonly}}placeholder="C.S. Lewis"{{/unless}} {{#readonly}}readonly{{/readonly}}>
     </div>
 </div>
 <div class="field">
-    <label class="label">{{#i18n 'label.publisher-opt'}}Publisher (optional){{/i18n}}</label>
+    <label class="label">{{#i18n 'label.publisher'}}Publisher{{/i18n}}{{^readonly}} {{#i18n 'label.suffix-optional'}}(optional){{/i18n}}{{/readonly}}</label>
     <div class="control">
         <input name="publisher" class="input" type="text" {{#unless readonly}}placeholder="Geoffrey Bles"{{/unless}} {{#readonly}}readonly{{/readonly}}>
     </div>
 </div>
 <div class="field">
-    <label class="label">{{#i18n 'label.repository-opt'}}Repository (optional){{/i18n}}</label>
+    <label class="label">{{#i18n 'label.repository'}}Repository{{/i18n}}{{^readonly}} {{#i18n 'label.suffix-optional'}}(optional){{/i18n}}{{/readonly}}</label>
     <div class="control">
         <input
             name="repository"
@@ -130,7 +130,7 @@
     </div>
 </div>
 <div class="field url">
-    <label class="label">{{#i18n 'label.url-opt'}}URL (optional){{/i18n}}</label>
+    <label class="label">{{#i18n 'label.url'}}URL{{/i18n}}{{^readonly}} {{#i18n 'label.suffix-optional'}}(optional){{/i18n}}{{/readonly}}</label>
     <div class="control">
         <input name="url" class="input" type="url" {{#unless readonly}}placeholder="https://www.wikidata.org/wiki/Q331656"{{/unless}} {{#readonly}}readonly{{/readonly}}>
     </div>

frontend/src/source-metadata/source-metadata-view.ts

@@ -114,8 +114,8 @@ export default class SourceMetadataView extends CompositeView {
             model: this.getNode("dateCreated"),
             name: "dateCreated",
             label: i18next.t(
-                "label.creation-date-opt",
-                "Creation date (optional)"
+                "label.creation-date",
+                "Creation date"
             ),
             additionalHelpText: i18next.t(
                 "upload.creation-date-help",
@@ -127,8 +127,8 @@ export default class SourceMetadataView extends CompositeView {
             model: this.getNode("dateRetrieved"),
             name: "dateRetrieved",
             label: i18next.t(
-                "label.retrieval-date-opt",
-                "Retrieval date (optional)"
+                "label.retrieval-date",
+                "Retrieval date"
             ),
             additionalHelpText: i18next.t(
                 "upload.retrieval-date-help",

frontend/src/style/source.sass

@@ -31,8 +31,11 @@
         padding-left: 0
         padding-right: 0
 
-    &.is-static input
-        @extend .is-static
+    &.is-static
+        input
+            @extend .is-static
+        .help, .help-text
+            display: none
 
 .source-list
     .source-summary