remove legacy Sengrid code

Author: avrampa

.env.example

@@ -1,6 +1,4 @@
 # Email Configuration
-SENDGRID_API_KEY=
-SENDGRID_FROM_EMAIL=
 MS_FROM_EMAIL=[email protected]
 EMAIL_SERVICE_TYPE=ms_graph
 

docs/email_digest_delivery_methods.md

@@ -47,13 +47,6 @@ This document summarizes all the methods we have tried (and considered) for send
 
 ---
 
-## 4. SendGrid or Third-Party SMTP Relay
-
-- **Approach:** Use a third-party SMTP service (e.g., SendGrid) to send as the service account.
-- **Status:** **Not attempted** (would require IT approval and setup).
-- **Blocker:**
-  - May not be allowed by organizational policy.
-
 ---
 
 ## 5. Distribution List/Group Delivery
@@ -75,7 +68,6 @@ This document summarizes all the methods we have tried (and considered) for send
 | MS Graph (App perms)  | Yes        | Blocked               | Need admin to grant permissions      |
 | MS Graph (Delegated)  | No         | Works (manual only)   | Not suitable for automation          |
 | SMTP (O365)           | Yes        | Blocked               | SMTP AUTH disabled for tenant        |
-| SendGrid/3rd-party    | Yes        | Not attempted         | Needs IT approval                    |
 | Distribution List     | Yes        | Ready                 | Blocked by above sending method      |
 
 ---

docs/email_system.md

@@ -12,7 +12,6 @@ The email system consists of the following components:
    - `EmailServiceBase`: Abstract base class defining the interface for all email services
    - `MSGraphEmailService`: Implementation using Microsoft Graph API with enterprise application authentication
    - `UserAuthEmailService`: Implementation using Azure CLI authentication
-   - `SendGridEmailService`: Alternative implementation using SendGrid
    - `EmailFactory`: Factory pattern for creating the appropriate service based on configuration
 
 2. **Weekly Digest Feature**
@@ -35,7 +34,7 @@ The email system consists of the following components:
 source venv/bin/activate
 
 # Install the required packages
-pip install python-dotenv msgraph-core azure-identity httpx sendgrid
+pip install python-dotenv msgraph-core azure-identity httpx
 ```
 
 ### Environment Variables
@@ -45,7 +44,7 @@ The following environment variables need to be set in your `.env.local` file:
 ```
 # Email Configuration
 [email protected]  # Email that will appear as the sender
-EMAIL_SERVICE_TYPE=ms_graph                  # Authentication type (ms_graph, user_auth, or sendgrid)
+EMAIL_SERVICE_TYPE=ms_graph                  # Authentication type (ms_graph or user_auth)
 
 # Azure Authentication for UNDP Enterprise Application
 TENANT_ID=b3e5db5e-2944-4837-99f5-7488ace54319  # UNDP tenant ID
@@ -78,13 +77,6 @@ Requirements:
 - Azure CLI installed and logged in with `az login`
 - User must have Mail.Send permissions in Microsoft Graph
 
-#### 3. SendGrid Authentication
-
-Alternative email provider if Microsoft Graph is not available.
-
-Requirements:
-- SendGrid API key
-- SendGrid from email address
 
 ### Azure AD Enterprise Application Configuration
 

scripts/email_requirements.txt

@@ -8,14 +8,12 @@
 
 from .email_service import EmailServiceBase
 from .msgraph_service import MSGraphEmailService
-from .sendgrid_service import SendGridEmailService
 from .user_auth_service import UserAuthEmailService
 
 logger = logging.getLogger(__name__)
 
 # Email service types
 MS_GRAPH = "ms_graph"
-SENDGRID = "sendgrid"
 USER_AUTH = "user_auth"
 
 # Default to USER_AUTH with Azure CLI authentication
@@ -35,8 +33,6 @@ def create_email_service(useUserAccessToken: bool = False) -> EmailServiceBase:
 
     if service_type == MS_GRAPH:
         return MSGraphEmailService(useUserAccessToken=useUserAccessToken)
-    elif service_type == SENDGRID:
-        return SendGridEmailService()
     elif service_type == USER_AUTH:
         return UserAuthEmailService()
     else:

src/services/email_factory.py

@@ -10,7 +10,6 @@
 
 from main import app
 from src.services.msgraph_service import MSGraphEmailService
-from src.services.sendgrid_service import SendGridEmailService
 
 client = TestClient(app)
 
@@ -24,15 +23,6 @@ def mock_msgraph_client():
         mock.return_value = mock_instance
         yield mock_instance
 
-@pytest.fixture
-def mock_sendgrid_client():
-    with patch('src.services.sendgrid_service.SendGridAPIClient') as mock:
-        mock_instance = MagicMock()
-        mock_response = MagicMock()
-        mock_response.status_code = 202
-        mock_instance.send = MagicMock(return_value=mock_response)
-        mock.return_value = mock_instance
-        yield mock_instance
 
 @pytest.mark.asyncio
 async def test_msgraph_send_email(mock_msgraph_client):
@@ -73,40 +63,7 @@ async def test_msgraph_send_notification(mock_msgraph_client):
     call_args = mock_msgraph_client.post.call_args[0]
     assert call_args[0] == "/me/sendMail"
 
-@pytest.mark.asyncio
-async def test_sendgrid_send_email(mock_sendgrid_client):
-    """Test sending email via SendGrid"""
-    # Setup
-    service = SendGridEmailService()
-    
-    # Test
-    result = await service.send_email(
-        to_emails=["[email protected]"],
-        subject="Test Subject",
-        content="Test Content"
-    )
-    
-    # Assert
-    assert result is True
-    mock_sendgrid_client.send.assert_called_once()
 
-@pytest.mark.asyncio
-async def test_sendgrid_send_notification(mock_sendgrid_client):
-    """Test sending notification via SendGrid"""
-    # Setup
-    service = SendGridEmailService()
-    
-    # Test
-    result = await service.send_notification_email(
-        to_email="[email protected]",
-        subject="Test Notification",
-        template_id="test-template",
-        dynamic_data={"name": "Test User"}
-    )
-    
-    # Assert
-    assert result is True
-    mock_sendgrid_client.send.assert_called_once()
 
 @pytest.mark.skip(reason="Requires database connection")
 def test_email_endpoints(headers: dict):