fix: april fools background image

Author: feildmaster

changelog.md

@@ -1,5 +1,8 @@
 # UnderScript Changelog
 
+## Version 0.62.3 (2025-04-09)
+1. Fixed April Fools messing up persistent background
+
 ## Version 0.62.2 (2025-04-09)
 1. Fixed April Fools setting being too aggressive
 

src/base/game/persistBGM.js

@@ -2,6 +2,7 @@ import eventManager from '../../utils/eventManager.js';
 import * as settings from '../../utils/settings/index.js';
 import { global } from '../../utils/global.js';
 import { isApril, IMAGES } from '../../utils/isApril.js';
+import { aprilFools } from '../vanilla/aprilFools.js';
 
 const setting = settings.register({
   name: 'Persist Arena (Background and Music)',
@@ -15,7 +16,7 @@ eventManager.on('GameStart', () => {
   eventManager.on('connect', (data) => {
     const val = sessionStorage.getItem(`underscript.bgm.${data.gameId}`);
     if (setting.value() && val) {
-      const path = isApril() ? IMAGES : 'images';
+      const path = isApril() && !aprilFools.value() ? IMAGES : 'images';
       $('body').css('background-image', `url('${path}/backgrounds/${val}.png')`);
       // Check special skins
       if (data.gameType !== 'BOSS' && global('profileSkinsEnabled')) {

src/base/vanilla/aprilFools.js

@@ -3,7 +3,7 @@ import * as settings from '../../utils/settings/index.js';
 import { isApril, IMAGES } from '../../utils/isApril.js';
 
 const year = `${new Date().getFullYear()}`;
-const aprilFools = settings.register({
+export const aprilFools = settings.register({
   name: 'Disable April Fools Jokes',
   key: 'underscript.disable.fishday',
   note: 'Disables *almost* everything.',
@@ -13,7 +13,8 @@ const aprilFools = settings.register({
     toggleFish($('body'));
   },
 });
-function isSoftDisabled() {
+
+export function isSoftDisabled() {
   return localStorage.getItem(aprilFools.key) === year;
 }
 
@@ -26,10 +27,10 @@ function toggleFish($el) {
 
   $el.find(`img[src*="undercards.net/${search}/"],img[src^="/${search}/"],img[src^="${search}/"]`).each((_, img) => {
     img.src = img.src.replace(search, replace);
-  }).on('error', () => aprilFools.set(year));
+  }).one('error', () => aprilFools.set(year));
   $el.find(`[style*="url(\\"${search}/"]`).each((i, img) => {
     img.style.background = img.style.background.replace(search, replace);
-  }).on('error', () => aprilFools.set(year));
+  }).one('error', () => aprilFools.set(year));
 }
 
 eventManager.on('undercards:season', () => {