Skip to content

Commit 68c4b49

Browse files
committed
doc: fix typos.
1 parent d78eb82 commit 68c4b49

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

README.md

+2-8
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
# Fetch code.
1111
git clone https://github.com/UCLA-VAST/minimap2-acceleration.git
1212

13-
# Make sure a C compiler, GNU make and zlib
14-
# development files are installed.
1513
# Build testbed.
1614
(cd testbed/ && make);
1715

@@ -37,7 +35,6 @@ testbed/minimap2 -ax map-pb ref.fa tgt.fa \
3735
### Build GPU kernel and run benchmarks
3836

3937
```bash
40-
# Make sure a C compiler and CUDA 10 is installed
4138
# Build CUDA kernel.
4239
(cd kernel/cuda/ && make);
4340

@@ -51,9 +48,6 @@ cmp out-1k.txt kernel-1k.txt
5148
### Build CPU SIMD kernel and run benchmarks
5249

5350
```bash
54-
# Make sure Intel Parallel Studio XE is installed
55-
# and you have a CPU with AVX2 support.
56-
5751
# Source Intel Parallel Studio XE environment.
5852
source /opt/tools/intel/parallel-studio/parallel_studio_xe_2019/psxevars.sh
5953

@@ -66,7 +60,7 @@ kernel/simd/kernel in-1k.txt kernel-1k.txt
6660

6761
# Advanced use: execute the kernel benchmark
6862
# with 14 threads, scatter affinity
69-
# and NUMA affinity on CPU 1.
63+
# and CPU binding for NUMA optimization.
7064
KMP_AFFINITY=granularity=fine,scatter \
7165
OMP_NUM_THREADS=14 \
7266
numactl --cpubind=1 \
@@ -457,7 +451,7 @@ If it outputs something that starts with `flags`, the CPU can run AVX2 programs.
457451
## <a name="limit"></a> Limitations and Notes
458452

459453
* Our accelerated kernels do not support spliced long reads. For example, acceleration of `minimap2 -ax splice ref.fa tgt.fa` is not yet supported.
460-
* Our accelerations are not yet integrated into the software. The code in this repository contains kernels for the chaining function itself, which can be driven by testbed generated chaining data. File input and output takes significant time in benchmarking, and we don’t count the time in the kernel execution. To achieve end-to-end acceleration, integration is required.
454+
* Our accelerations are not yet integrated into the software. The code in this repository contains kernels for the chaining function itself, which can be driven by testbed generated chaining data. File input and output takes significant time in benchmarking, and we don’t count the time as part of the kernel execution. To achieve end-to-end acceleration, integration is required.
461455
* We use an assumption that the quality of output does not degrade when we choose the lookup depth of the dynamic programming algorithm to be 64, based on the claim in Li, H. (2018).
462456
* We inherit most of [limitations of Minimap2][35].
463457
* For integration, we recommend implementing the whole `mm_chain_dp` function in all accelerations solutions to reduce output communication. The reason we choose the score value as the output point is that we can better evaluate the correctness in fine grain. We also recommend integrating the seeding part.

0 commit comments

Comments
 (0)