Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTC_DCHECKs should not abort #7

Open
sebjf opened this issue Sep 15, 2020 · 0 comments
Open

RTC_DCHECKs should not abort #7

sebjf opened this issue Sep 15, 2020 · 0 comments

Comments

@sebjf
Copy link
Member

sebjf commented Sep 15, 2020

There are dchecks for things like multi-channel microphones, that should raise a warning, but not terminate the application
sebjf pushed a commit that referenced this issue Oct 6, 2020
Merge to M86: Make VP9 correctly accept middle-layer singlecast
7b20cbe 
Unfortunate typo and week tests made it so if only a middle spatial layer
is active, vp9 encoder would be configured to send two top layers.

Bug: webrtc:11319, chromium:1130960
Change-Id: I460c245044f60ea7e0127c0e4134d0edab85f4f3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185047
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Philip Eliasson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#7}
Cr-Branched-From: 93a9d19-refs/heads/master@{#31969}
sebjf pushed a commit that referenced this issue Oct 6, 2020
Revert "Merge to M86: Make VP9 correctly accept middle-layer singlecast"
453ceb5 
This reverts commit 7b20cbe.

Reason for revert: Landed wrong CL

Original change's description:
> Merge to M86: Make VP9 correctly accept middle-layer singlecast
> 
> Unfortunate typo and week tests made it so if only a middle spatial layer
> is active, vp9 encoder would be configured to send two top layers.
> 
> Bug: webrtc:11319, chromium:1130960
> Change-Id: I460c245044f60ea7e0127c0e4134d0edab85f4f3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185047
> Commit-Queue: Ilya Nikolaevskiy <[email protected]>
> Reviewed-by: Philip Eliasson <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4240@{#7}
> Cr-Branched-From: 93a9d19-refs/heads/master@{#31969}

[email protected],[email protected],[email protected]

Change-Id: I6f96a02bc282fc44261cad9cfbf07438503098ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11319
Bug: chromium:1130960
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185048
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#8}
Cr-Branched-From: 93a9d19-refs/heads/master@{#31969}
camnewnham pushed a commit to camnewnham/webrtc that referenced this issue Nov 5, 2020
Revert "NV12 support for VP8 simulcast"
7ef8093 
This reverts commit 76d3e7a.

Reason for revert: Causes multiple Chromium WPT tests to crash, preventing rolls.

Sample failed run:
https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/685757?

Sample stack trace:
#0 0x7ff8623fbde9 base::debug::CollectStackTrace()
STDERR: UCL-VR#1 0x7ff862311ca3 [2665012:17:1009/162250.249660:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652370324, interval (us) = 834
STDERR: base::debug::StackTrace::StackTrace()
STDERR: UCL-VR#2 0x7ff8623fb93b base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR: UCL-VR#3 0x7ff857a70140 [2665012:17:1009/162250.249947:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652370634, interval (us) = 742
STDERR: (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f)
STDERR: UCL-VR#4 0x7ff85778edb1 gsignal
STDERR: UCL-VR#5 0x7ff857778537 abort
STDERR: UCL-VR#6 0x7ff855d5eee2 [2665012:17:1009/162250.250342:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652371030, interval (us) = 706
STDERR: [2665012:17:1009/162250.250514:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652371204, interval (us) = 963
STDERR: rtc::webrtc_checks_impl::FatalLog()
STDERR: UCL-VR#7 0x7ff855f14e62 webrtc::LibvpxVp8Encoder::PrepareRawImagesForEncoding()
STDERR: UCL-VR#8 0x7ff855f14412 webrtc::LibvpxVp8Encoder::Encode()
STDERR: UCL-VR#9 0x7ff855bae765 webrtc::SimulcastEncoderAdapter::Encode()
STDERR: UCL-VR#10 0x7ff85607d598 webrtc::VideoStreamEncoder::EncodeVideoFrame()
STDERR: UCL-VR#11 0x7ff85607c60d webrtc::VideoStreamEncoder::MaybeEncodeVideoFrame()
STDERR: pixiv#12 0x7ff8560816f5 webrtc::webrtc_new_closure_impl::ClosureTask<>::Run()
STDERR: pixiv#13 0x7ff855b352b5 (anonymous namespace)::WebrtcTaskQueue::RunTask()
STDERR: pixiv#14 0x7ff855b3531e base::internal::Invoker<>::RunOnce()
STDERR: pixiv#15 0x7ff86239785b base::TaskAnnotator::RunTask()
STDERR: pixiv#16 0x7ff8623c8557 base::internal::TaskTracker::RunSkipOnShutdown()
STDERR: pixiv#17 0x7ff8623c7d92 base::internal::TaskTracker::RunTask()
STDERR: pixiv#18 0x7ff862415a06 base::internal::TaskTrackerPosix::RunTask()
STDERR: pixiv#19 0x7ff8623c75e6 base::internal::TaskTracker::RunAndPopNextTask()
STDERR: pixiv#20 0x7ff8623d3a8d base::internal::WorkerThread::RunWorker()
STDERR: pixiv#21 0x7ff8623d368d base::internal::WorkerThread::RunPooledWorker()
STDERR: pixiv#22 0x7ff862416509 base::(anonymous namespace)::ThreadFunc()
STDERR: pixiv#23 0x7ff857a64ea7 start_thread 

Original change's description:
> NV12 support for VP8 simulcast
>
> Tested using video_loopback with generated NV12 frames.
>
> Bug: webrtc:11635, webrtc:11975
> Change-Id: I14b2d663c55a83d80e48e226fcf706cb18903193
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186722
> Commit-Queue: Evan Shrubsole <[email protected]>
> Reviewed-by: Ilya Nikolaevskiy <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#32325}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11635
Bug: webrtc:11975
Change-Id: I61c8aed1270bc9c2f7f0577fa5ca717a325f548a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187484
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: Ilya Nikolaevskiy <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#32369}
camnewnham pushed a commit to camnewnham/webrtc that referenced this issue Nov 5, 2020
Revert "Reland "Replace sigslot usages with robocaller library.""
ff79132 
This reverts commit c5f7108.

Reason for revert: Causes Chromium WPT Tests to fail, preventing rolls.

Sample failed run:
https://ci.chromium.org/p/chromium/builders/try/linux-rel/511995?

Sample logs:

STDERR: # Fatal error in: ../../third_party/webrtc/pc/peer_connection.cc, line 575
STDERR: # last system error: 0
STDERR: # Check failed: (signaling_thread())->IsCurrent()
STDERR: # Received signal 6
STDERR: #0 0x7f81d39e3de9 base::debug::CollectStackTrace()
STDERR: UCL-VR#1 0x7f81d38f9ca3 base::debug::StackTrace::StackTrace()
STDERR: UCL-VR#2 0x7f81d39e393b base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR: UCL-VR#3 0x7f81c9054140 (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f)
STDERR: UCL-VR#4 0x7f81c8d72db1 gsignal
STDERR: UCL-VR#5 0x7f81c8d5c537 abort
STDERR: UCL-VR#6 0x7f81c7344032 rtc::webrtc_checks_impl::FatalLog()
STDERR: UCL-VR#7 0x7f81c722e5c0 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>()
STDERR: UCL-VR#8 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach()
STDERR: UCL-VR#9 0x7f81c72d6e8e webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>()
STDERR: UCL-VR#10 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach()
STDERR: UCL-VR#11 0x7f81c71c6df3 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>()
STDERR: pixiv#12 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach()
STDERR: pixiv#13 0x7f81c73135bc rtc::OpenSSLStreamAdapter::ContinueSSL()
STDERR: pixiv#14 0x7f81c7312fd4 rtc::OpenSSLStreamAdapter::OnEvent()
STDERR: pixiv#15 0x7f81c71c30d9 cricket::StreamInterfaceChannel::OnPacketReceived()
STDERR: pixiv#16 0x7f81c71c640a cricket::DtlsTransport::OnReadPacket()
STDERR: pixiv#17 0x7f81c71cad61 cricket::P2PTransportChannel::OnReadPacket()
STDERR: pixiv#18 0x7f81c71bc90f cricket::Connection::OnReadPacket()
STDERR: pixiv#19 0x7f81c71e6255 cricket::UDPPort::HandleIncomingPacket()
STDERR: pixiv#20 0x7f81cd1f1bff blink::(anonymous namespace)::IpcPacketSocket::OnDataReceived()
STDERR: pixiv#21 0x7f81cd1f645d blink::P2PSocketClientImpl::DataReceived()
STDERR: pixiv#22 0x7f81cd50a16b network::mojom::blink::P2PSocketClientStubDispatch::Accept()
STDERR: pixiv#23 0x7f81d2b4f642 mojo::InterfaceEndpointClient::HandleValidatedMessage()
STDERR: pixiv#24 0x7f81d2b5304b mojo::MessageDispatcher::Accept()
STDERR: pixiv#25 0x7f81d2b50bb1 mojo::InterfaceEndpointClient::HandleIncomingMessage()
STDERR: pixiv#26 0x7f81d2b58a3a mojo::internal::MultiplexRouter::ProcessIncomingMessage()
STDERR: pixiv#27 0x7f81d2b57f7f mojo::internal::MultiplexRouter::Accept()
STDERR: pixiv#28 0x7f81d2b5304b mojo::MessageDispatcher::Accept()
STDERR: pixiv#29 0x7f81d2b48851 mojo::Connector::DispatchMessage()
STDERR: pixiv#30 0x7f81d2b492e7 mojo::Connector::ReadAllAvailableMessages()
STDERR: pixiv#31 0x7f81d2b490a3 mojo::Connector::OnHandleReadyInternal()
STDERR: pixiv#32 0x7f81d2b498f0 mojo::SimpleWatcher::DiscardReadyState()
STDERR: #33 0x7f81d2d0e67a mojo::SimpleWatcher::OnHandleReady()
STDERR: #34 0x7f81d2d0eb2b base::internal::Invoker<>::RunOnce()
STDERR: #35 0x7f81d397f85b base::TaskAnnotator::RunTask()
STDERR: #36 0x7f81d399a04c base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
STDERR: #37 0x7f81d3999c78 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
STDERR: #38 0x7f81d391fe64 base::MessagePumpDefault::Run()
STDERR: #39 0x7f81d399a8dc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
STDERR: #40 0x7f81d395ae55 base::RunLoop::Run()
STDERR: #41 0x7f81d39c87f2 base::Thread::Run()




Original change's description:
> Reland "Replace sigslot usages with robocaller library."
>
> This is a reland of 40261c3
>
> Note: Instead of changing the type of JsepTransportController->SignalSSLHandshakeError
> added a new member with a different name and used it in webrtc code.
> After this change do two more follow up CLs to completely remove the old code
> from google3.
>
> Original change's description:
> > Replace sigslot usages with robocaller library.
> >
> > - Replace all the top level signals from jsep_transport_controller.
> > - There are still sigslot usages in this file so keep the inheritance
> >   and that is the reason for not having a binary size gain in this CL.
> >
> > Bug: webrtc:11943
> > Change-Id: I249d3b9710783aef70ba273e082ceeafe3056898
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185540
> > Commit-Queue: Lahiru Ginnaliya Gamathige <[email protected]>
> > Reviewed-by: Mirko Bonadei <[email protected]>
> > Reviewed-by: Karl Wiberg <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#32321}
>
> Bug: webrtc:11943
> Change-Id: Ia07394ee395f94836f6b576c3a97d119a7678e1a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186946
> Commit-Queue: Lahiru Ginnaliya Gamathige <[email protected]>
> Reviewed-by: Karl Wiberg <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#32359}

[email protected],[email protected],[email protected]

Change-Id: I6bce1775d10758ac4a9d05b855f473dd70bd9815
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11943
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187487
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/heads/master@{#32372}
sebjf pushed a commit that referenced this issue May 13, 2021
@alebzk
[cherry pick] AGC2: retuning and large refactoring
02400a3 
- Bug fix: the desired initial gain quickly dropped to 0 dB hence
  starting a call with a too low level
- New tuning to make AGC2 more robust to VAD mistakes
- Smarter max gain increase speed: to deal with an increased threshold
  of adjacent speech frames, the gain applier temporarily allows a
  faster gain increase to deal with a longer time spent waiting for
  enough speech frames in a row to be observed
- Saturation protector isolated from `AdaptiveModeLevelEstimator` to
  simplify the unit tests for the latter (non bit-exact change)
- AGC2 adaptive digital config: unnecessary params deprecated
- Code readability improvements
- Data dumps clean-up and better naming

(cherry picked from commit 980c460)
NOTRY=true

Bug: chromium:1199259,webrtc:7494
Change-Id: I4e36059bdf2566cc2a7e1a7e95b7430ba9ae9844
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215140
Commit-Queue: Alessio Bazzica <[email protected]>
Reviewed-by: Jesus de Vicente Pena <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#33736}
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215782
Reviewed-by: Minyue Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/4472@{#7}
Cr-Branched-From: 3e0c60b-refs/heads/master@{#33644}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebjf