Merge pull request #49 from UBC-MDS/16-additional_tests

16 additional tests

Author: carrieklc

pydistrrr/get_all_distances.py

@@ -29,7 +29,7 @@ def get_all_distances(point, data, metric = "euclidean"):
     Returns
     -------
     list
-    numeric vector of length n containing distances for each row of data
+    numeric list of length n containing distances for each row of data
 
     Example
     -------
@@ -47,6 +47,11 @@ def get_all_distances(point, data, metric = "euclidean"):
     if not isinstance(point, list):
         raise Exception("the point argument should be type list")
 
+    # raise error if point isn't all numeric
+    for obs in point:
+        if not isinstance(obs, int) and not isinstance(obs, float):
+            raise Exception("point argument should be a list containing only type float or int")
+
     # number of observations in data frame
     n = data.shape[0]
     k = data.shape[1]

pydistrrr/test/test_get_all_distances.py

@@ -92,9 +92,18 @@ def test_point_correct_length():
 
 def test_metric_input():
     """
-    dist should be a string and one of 'cosine', 'euclidean' or 'manhattan'
+    metric should be a string and one of 'cosine', 'euclidean' or 'manhattan'
     """
     try:
         get_all_distances(ref_vec,df, metric = "cityblock")
     except:
         assert True
+
+def test_point_types():
+    """
+    Test for error if input 'point' contains items other than numerics
+    """
+    try:
+        get_all_distances(["a","b","c"],df)
+    except:
+        assert True