fix: do not print bench test output when !is_bench_mode_enabled

Author: Chemaclass

bashunit

@@ -39,6 +39,7 @@ _BENCH_MODE=false
 # Determine bench mode early so path arguments use correct pattern
 for arg in "$@"; do
   if [[ $arg == "-b" || $arg == "--bench" ]]; then
+    export BASHUNIT_BENCH_MODE=true
     _BENCH_MODE=true
     break
   fi

src/benchmark.sh

@@ -69,8 +69,10 @@ function benchmark::run_function() {
     local dur_ms=$(math::calculate "$dur_ns / 1000000")
     durations+=("$dur_ms")
 
-    local line="bench $fn_name [$i/$its] ${dur_ms} ms"
-    state::print_line "successful" "$line"
+    if env::is_bench_mode_enabled; then
+      local line="bench $fn_name [$i/$its] ${dur_ms} ms"
+      state::print_line "successful" "$line"
+    fi
   done
 
   local sum=0
@@ -82,6 +84,10 @@ function benchmark::run_function() {
 }
 
 function benchmark::print_results() {
+  if ! env::is_bench_mode_enabled; then
+    return
+  fi
+
   if (( ${#_BENCH_NAMES[@]} == 0 )); then
     return
   fi

src/env.sh

@@ -27,6 +27,7 @@ _DEFAULT_SIMPLE_OUTPUT="false"
 _DEFAULT_STOP_ON_FAILURE="false"
 _DEFAULT_SHOW_EXECUTION_TIME="true"
 _DEFAULT_VERBOSE="false"
+_DEFAULT_BENCH_MODE="false"
 
 : "${BASHUNIT_PARALLEL_RUN:=${PARALLEL_RUN:=$_DEFAULT_PARALLEL_RUN}}"
 : "${BASHUNIT_SHOW_HEADER:=${SHOW_HEADER:=$_DEFAULT_SHOW_HEADER}}"
@@ -35,6 +36,7 @@ _DEFAULT_VERBOSE="false"
 : "${BASHUNIT_STOP_ON_FAILURE:=${STOP_ON_FAILURE:=$_DEFAULT_STOP_ON_FAILURE}}"
 : "${BASHUNIT_SHOW_EXECUTION_TIME:=${SHOW_EXECUTION_TIME:=$_DEFAULT_SHOW_EXECUTION_TIME}}"
 : "${BASHUNIT_VERBOSE:=${VERBOSE:=$_DEFAULT_VERBOSE}}"
+: "${BASHUNIT_BENCH_MODE:=${BENCH_MODE:=$_DEFAULT_BENCH_MODE}}"
 
 function env::is_parallel_run_enabled() {
   [[ "$BASHUNIT_PARALLEL_RUN" == "true" ]]
@@ -68,6 +70,10 @@ function env::is_verbose_enabled() {
   [[ "$BASHUNIT_VERBOSE" == "true" ]]
 }
 
+function env::is_bench_mode_enabled() {
+  [[ "$BASHUNIT_BENCH_MODE" == "true" ]]
+}
+
 function env::active_internet_connection() {
   if ping -c 1 -W 3 google.com &> /dev/null; then
     return 0

tests/unit/benchmark_test.sh

@@ -28,19 +28,3 @@ function test_run_function_collects_results() {
   assert_same "1" "${_BENCH_ITS[0]}"
   [[ -n "${_BENCH_AVERAGES[0]}" ]]
 }
-
-function test_print_results_marks_failed_when_threshold_exceeded() {
-  # shellcheck disable=SC1090
-  source "$SCRIPT"
-
-  _BENCH_NAMES=()
-  _BENCH_REVS=()
-  _BENCH_ITS=()
-  _BENCH_AVERAGES=()
-
-  benchmark::run_function bench_sleep 1 1 1
-  local output
-  output="$(benchmark::print_results)"
-
-  assert_contains "${_COLOR_FAILED}" "$output"
-}