Support lib property in tsconfig.json

[michaelmesser]

When I use the new lib property in tsconfig.json I get an error (works fine with tsc).

[basarat]

Note : this is flag that I believe the user is speaking of : microsoft/TypeScript#6974 🌹

[michaelmesser]

Working on PR

[michaelmesser]

How would I add a array of strings property? I see string, boolean, and number. Should I extend the validator to deal with arrays or just write code specific to the lib property?

[basarat]

Should I extend the validator to deal with arrays or just write code specific to the lib property

Nothing stays simple ¯\_(ツ)_/¯ (simpleValidator.ts) 🌹

Add an any type to Simple Validator and don't do any validation / error reporting < this would be the quickest way. I'd like to move to better JSON validation / autocomplete in the future so don't invest too much of your 😓 and 🔴

[michaelmesser]

@basarat http://json-schema.org/ looks like a decent JSON validator. I believe there is an atom plugin with autocomplete.

[michaelmesser]

https://github.com/OmniSharp/atom-json-schema/blob/master/README.md

[michaelmesser]

I got the lib property to pass validation but it does not work.

[basarat]

I got the lib property to pass validation but it does not work.

Guess you need to change the lib.d.ts adding logic : https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/lang/core/languageServiceHost2.ts#L226-L228 🌹

[michaelmesser]

Is there a way to access the compiler host from atom-typescript?

On Apr 17, 2016, at 5:54 AM, Basarat Ali Syed notifications@github.com wrote:

I got the lib property to pass validation but it does not work.

Guess you need to change the lib.d.ts adding logic : https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/lang/core/languageServiceHost2.ts#L226-L228 https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/lang/core/languageServiceHost2.ts#L226-L228

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #918 (comment)

[michaelmesser]

Someone already wrote a json-schema definition for tsconfig.json. http://json.schemastore.org/tsconfig

[michaelmesser]

https://github.com/bali182/autocomplete-json is another atom plugin

[basarat]

I did a quick readthrough of the vscode codebase. It seems to have its schema validator a bit custom : https://github.com/Microsoft/vscode/blob/42a2cd566530c5ba1f5dd3ad9bacd454579cbc49/src/vs/languages/json/common/jsonSchemaService.ts

So for alm I'll be extending simpleValidator to support the full tsconfig validation in its current state. Even then it should be simpler than creating a jsonschema validator. I'll think through adding json autocomplete later

[basarat]

http://json.schemastore.org/tsconfig

FWIW this is missing a lot of options including lib :-/ so definitely not worth using for cutting edge stuff.

That said I wrote a bunch of start from scratch tsconfig.json handling in alm and I got it working. You are welcome to jump over there and see files like tsconfig.ts / typescriptDir.ts / tsconfigValidation.ts / projectDataLoader.ts.

In the end is just a matter of loading the right lib.d.ts into the compilation context (in the language service host I pointed to in atom-typescript code base) so that is still worth a try if someone wants to do a lazy PR.

More details : microsoft/TypeScript#6974 (comment)