Are pull diagnostics implemented in monaco-languageclient?

[ghord]

When working with csharp lsp, it uses pull model for diagnostics. Specifically, when I open file with textDocument/didOpen vscode pulls all previously registered diagnostics capabilities with textDocument/diagnostic.

I'm having trouble getting it to work on monaco-languageclient.

Server correctly registers capabilities

{ "jsonrpc":"2.0","id":2,"method":"client/registerCapability","params":{"registrations":[{"id":"1494091e-a24d-45b3-8e15-532fe9c8c62b","method":"textDocument/diagnostic","registerOptions":{"identifier":"DocumentCompilerSemantic","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"ddc3937a-d9f9-4e04-a91d-334669dc197f","method":"textDocument/diagnostic","registerOptions":{"workDoneProgress":true,"identifier":"enc","interFileDependencies":true,"workspaceDiagnostics":true}},{"id":"93fe4f63-176e-40a8-9c1f-645a4c68f9aa","method":"textDocument/diagnostic","registerOptions":{"identifier":"XamlDiagnostics","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"3262783c-b3a2-4c7a-a392-fc03eecf4052","method":"textDocument/diagnostic","registerOptions":{"workDoneProgress":true,"identifier":"HotReloadDiagnostics","interFileDependencies":true,"workspaceDiagnostics":true}},{"id":"0240400a-edae-4e70-8ae3-8aeb25ddb11c","method":"textDocument/diagnostic","registerOptions":{"identifier":"FileBasedPrograms","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"bedb01be-b807-4a5c-8412-efa1b5f6135b","method":"textDocument/diagnostic","registerOptions":{"identifier":"NonLocal","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"94e59524-46b9-4785-be01-0cca8baf3488","method":"textDocument/diagnostic","registerOptions":{"identifier":"DocumentAnalyzerSyntax","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"f04c2503-d921-4355-9197-83c9ebb0100c","method":"textDocument/diagnostic","registerOptions":{"identifier":"syntax","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"b3cc8e71-c828-4f5b-8719-1fea5dc2bcd2","method":"textDocument/diagnostic","registerOptions":{"identifier":"DocumentAnalyzerSemantic","interFileDependencies":true,"workspaceDiagnostics":false}},{"id":"f61c8356-d7d0-4c4a-9030-7eadc9fb00de","method":"textDocument/diagnostic","registerOptions":{"workDoneProgress":true,"identifier":"WorkspaceDocumentsAndProject","interFileDependencies":true,"workspaceDiagnostics":true}}]}}

But when I open file in monaco editor, textDocument/diagnostic are not called. Is this something I need to implement myself or do I need to troubleshoot my monaco-languageclient?

[ghord]

To answer the question: Yes, pull diagnostics are supported.

The thing I was missing was editor service override. Without it, vscode-languageclient though the file was not in visible tab and diagnostics were not pulled.

[kaisalmen]

@ghord thank you for your feedback. We should include this in the troubleshooting section.