Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fails to set item on results if id field is integer #4

Open
jonotron opened this issue Oct 3, 2018 · 0 comments
Open

fails to set item on results if id field is integer #4

jonotron opened this issue Oct 3, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@jonotron
Copy link
Member

jonotron commented Oct 3, 2018

If you supply documents prop where the id field is an integer, the item property of the results is not set.

I believe this is because Lunr converts the ref field to a string
@jonotron jonotron added the good first issue Good for newcomers label Oct 3, 2018
@jonotron jonotron added bug Something isn't working and removed good first issue Good for newcomers labels Oct 12, 2018
RoranDangerous added a commit to RoranDangerous/react-search-lunr that referenced this issue Oct 27, 2018
@RoranDangerous
Fixed bug TwoStoryRobot#4
0aa22fb 
Id field is compared by value.
jonotron added a commit that referenced this issue Oct 27, 2018
@jonotron
Merge pull request #18 from RoranDangerous/patch-1
b5cdcb6 
Fixed bug #4: id field is compared by value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonotron