-
Notifications
You must be signed in to change notification settings - Fork 10
Significantly improve the Libtask library using ideas from Mooncake / ReverseDiff #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@willtebbutt and I have discussed this a few times during meetings. Will, can you add your plan here? |
Regarding the issues above linked above.
The first example isn't a segfault, it's an OOM error on x86. Additionally, TuringLang/Turing.jl#2379 (comment) appears to be a Windows specific issue. In both cases, it's quite unclear to me what relationship we believe that these have to the introduction of ideas from Mooncake / ReverseDiff . @yebai could you explain how you think these are related? |
No, they are not directly related -- ideas from Mooncake and ReverseDiff are mainly to improve the robustness and maintainability of the Libtask implementation. |
Re TuringLang/Turing.jl#2379 -- I've just spoken with @mhauru and @penelopeysm and apparently we've not seen it happen again since it was initially reported. If it pops up again we can take a look, but otherwise I'm going to assume that I'm unlikely to see it. |
Would you assume that you don’t observe it? ;)
|
TODO
Edit this issue with more details about what needs to be done.
Known issues
TracedRNG isn't deterministic even on the same architecture Particle Gibbs reproducibly gives different results on x64 vs x86 AdvancedPS.jl#108-- this has been resolved independently of this issue.The text was updated successfully, but these errors were encountered: