Skip to content

Significantly improve the Libtask library using ideas from Mooncake / ReverseDiff #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhauru opened this issue Dec 5, 2024 · 5 comments
Assignees

Comments

@mhauru
Copy link
Member

mhauru commented Dec 5, 2024

TODO

Edit this issue with more details about what needs to be done.

Known issues

@yebai
Copy link
Member

yebai commented Dec 16, 2024

@willtebbutt and I have discussed this a few times during meetings. Will, can you add your plan here?

@willtebbutt
Copy link
Member

Regarding the issues above linked above.

Examples of a segfault with current Libtask: here and TuringLang/Turing.jl#2379 (comment)

The first example isn't a segfault, it's an OOM error on x86. Additionally, TuringLang/Turing.jl#2379 (comment) appears to be a Windows specific issue.

In both cases, it's quite unclear to me what relationship we believe that these have to the introduction of ideas from Mooncake / ReverseDiff . @yebai could you explain how you think these are related?

@yebai
Copy link
Member

yebai commented Feb 28, 2025

In both cases, it's quite unclear to me what relationship we believe that these have to the introduction of ideas from Mooncake / ReverseDiff . @yebai could you explain how you think these are related?

No, they are not directly related -- ideas from Mooncake and ReverseDiff are mainly to improve the robustness and maintainability of the Libtask implementation.

@willtebbutt
Copy link
Member

Re TuringLang/Turing.jl#2379 -- I've just spoken with @mhauru and @penelopeysm and apparently we've not seen it happen again since it was initially reported. If it pops up again we can take a look, but otherwise I'm going to assume that I'm unlikely to see it.

@penelopeysm
Copy link
Member

penelopeysm commented Feb 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants