-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSMC with Optional Resampling #24
Comments
I personally don't see any problems with resampling at every step. Although, Chopin's implementation of CSMC sets |
Ah okay, so he must show how to handle the weights in the case of no resampling somewhere in the code base then. Oh wait it's literally in the code snippet you shared. He just sets the value and doesn't update the weight. That feels a bit strange to me |
The CSMC class he defines only overloads |
Generalising this issue to talk about all issues related to the implementation details of CSMC. Our previous approach was saving the filtered states but this doesn't work for Rao-Blackwellisation if we're going to "insert" the reference trajectory at the end of the predict step. In this case the Gaussian state is essentially corrected twice leading to the wrong estimates. I've done a temporary fix by saving the proposed states but I think the better idea would be to save the filtered states and update the ref after the update step. |
What I mean is that during |
The definitions of CSMC that I can find seem to assume that resampling takes place at every step and so don't worry about setting the weight for the reference trajectory.
We need to think carefully about what this weight should be.
The text was updated successfully, but these errors were encountered: