Skip to content

Commit 2943cca

Browse files
committed
ci: use cimg/node:14 and node orb
Unit tests currently fail on Node 16+ because of a problem with scratch-audio. Once that's fixed, we should change this to use `cimg/node:lts-browsers` instead.
1 parent d781bf4 commit 2943cca

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.circleci/config.yml

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
version: 2.1
22
orbs:
3+
node: circleci/[email protected]
34
browser-tools: circleci/[email protected]
45
aliases:
56
- &save_git_cache
@@ -42,10 +43,12 @@ aliases:
4243
- v3-npm-
4344
- &defaults
4445
docker:
45-
- image: cimg/node:12.22.11-browsers
46+
# TODO: fix scratch-audio and change this to `cimg/node:lts-browsers`
47+
- image: cimg/node:14.20-browsers
4648
auth:
4749
username: $DOCKERHUB_USERNAME
4850
password: $DOCKERHUB_PASSWORD
51+
executor: node/default
4952
working_directory: ~/repo
5053

5154
jobs:
@@ -57,7 +60,7 @@ jobs:
5760
steps:
5861
- *restore_git_cache
5962
- checkout
60-
- run: npm ci
63+
- node/install-packages
6164
- run:
6265
name: Lint
6366
command: npm run test:lint -- --quiet --output-file test-results/eslint-results.xml --format junit
@@ -90,7 +93,7 @@ jobs:
9093
steps:
9194
- *restore_git_cache
9295
- checkout
93-
- run: npm ci
96+
- node/install-packages
9497
- *save_git_cache
9598
- *save_npm_cache
9699
lint:

0 commit comments

Comments
 (0)